From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter
Date: Fri, 15 Jan 2010 21:07:06 +0100 [thread overview]
Message-ID: <4B50CAEA.6070900@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
The missing '@' broke 'udp::<port>@:<port>' parsing.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
qemu-char.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index b13f8d4..a8a92f5 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2314,7 +2314,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
qemu_opt_set(opts, "backend", "udp");
if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port, &pos) < 2) {
host[0] = 0;
- if (sscanf(p, ":%32[^,]%n", port, &pos) < 1) {
+ if (sscanf(p, ":%32[^@,]%n", port, &pos) < 1) {
fprintf(stderr, "udp #1\n");
goto fail;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next reply other threads:[~2010-01-15 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 20:07 Jan Kiszka [this message]
2010-01-18 9:24 ` [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter Gerd Hoffmann
2010-01-18 10:21 ` Jan Kiszka
2010-01-18 10:47 ` Gerd Hoffmann
2010-01-18 11:15 ` [Qemu-devel] [PATCH][STABLE] Drop debug printfs from qemu_chr_parse_compat Jan Kiszka
2010-01-18 11:25 ` [Qemu-devel] " Gerd Hoffmann
2010-02-28 13:19 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B50CAEA.6070900@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.