Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp: parameter

[Gerd Hoffmann <kraxel@redhat.com>]

On 01/18/10 11:21, Jan Kiszka wrote:
> Gerd Hoffmann wrote:
>> On 01/15/10 21:07, Jan Kiszka wrote:
>>> The missing '@' broke 'udp::<port>@:<port>' parsing.
>>
>>>            if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)<   2) {
>>>                host[0] = 0;
>>> -            if (sscanf(p, ":%32[^,]%n", port,&pos)<   1) {
>>> +            if (sscanf(p, ":%32[^@,]%n", port,&pos)<   1) {
>>
>> Indeed.
>>
>>>                    fprintf(stderr, "udp #1\n");
>>
>> While you are at it, can you also zap this debug leftover?
>
> Looks like there are three of them in qemu_chr_parse_compat - kill them all?

Yes.

thanks,
   Gerd