* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
@ 2010-01-12 19:02 Khasim Syed Mohammed
2010-01-17 0:19 ` Tom
0 siblings, 1 reply; 8+ messages in thread
From: Khasim Syed Mohammed @ 2010-01-12 19:02 UTC (permalink / raw)
To: u-boot
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
2010-01-12 19:02 [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching Khasim Syed Mohammed
@ 2010-01-17 0:19 ` Tom
0 siblings, 0 replies; 8+ messages in thread
From: Tom @ 2010-01-17 0:19 UTC (permalink / raw)
To: u-boot
Khasim Syed Mohammed wrote:
> From 9045377f255e8a59450a6957e63366b4963281ae Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Fri, 8 Jan 2010 20:20:41 +0530
> Subject: [PATCH] Enable I2C bus switching
>
> OMAP3 supports Multiple I2C channels, this patch allows
> us to use i2c dev <bus no> command to switch between busses.
>
> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> ---
> drivers/i2c/omap24xx_i2c.c | 5 +++++
> include/configs/omap3_beagle.h | 4 ++++
> 2 files changed, 9 insertions(+), 0 deletions(-)
This patch fails to merge because of the recent usb changes in omap.
Please rebase this patchset and resubmit.
>
> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
> index ff18991..e8c8184 100644
> --- a/drivers/i2c/omap24xx_i2c.c
> +++ b/drivers/i2c/omap24xx_i2c.c
> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>
> return 0;
> }
> +
> +int i2c_get_bus_num(void)
> +{
> + return (int) current_bus;
> +}
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index d1c9cd0..ff6d432 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -100,6 +100,10 @@
> /* DDR - I use Micron DDR */
> #define CONFIG_OMAP3_MICRON_DDR 1
>
> +/* Enable Multi Bus support for I2C */
> +#define CONFIG_I2C_MULTI_BUS 1
> +#define CONFIG_SYS_I2C_NOPROBES {0x0, 0x0}
> +
Most (All ?) of the configs I reviewed set the addr element
to a valid address. I do not believe 0 is a valid address
on omap. If the intent is a double negative
{0, 0} == probe all
then add a comment.
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
@ 2010-01-18 13:55 Khasim Syed Mohammed
2010-01-24 0:05 ` Tom
0 siblings, 1 reply; 8+ messages in thread
From: Khasim Syed Mohammed @ 2010-01-18 13:55 UTC (permalink / raw)
To: u-boot
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
2010-01-18 13:55 Khasim Syed Mohammed
@ 2010-01-24 0:05 ` Tom
2010-01-25 14:10 ` Khasim Syed Mohammed
2010-02-06 7:30 ` Dirk Behme
0 siblings, 2 replies; 8+ messages in thread
From: Tom @ 2010-01-24 0:05 UTC (permalink / raw)
To: u-boot
Khasim Syed Mohammed wrote:
> From 9bb1c3501c8f098dac6e224c99e409ebf92b0ab9 Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <khasim@ti.com>
> Date: Mon, 18 Jan 2010 18:11:14 +0530
> Subject: [PATCH] Enable I2C bus switching
>
> OMAP3 supports Multiple I2C channels, this patch allows
> us to use i2c dev <bus no> command to switch between busses.
>
> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> ---
> drivers/i2c/omap24xx_i2c.c | 5 +++++
> include/configs/omap3_beagle.h | 6 ++++++
> 2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
> index ff18991..e8c8184 100644
> --- a/drivers/i2c/omap24xx_i2c.c
> +++ b/drivers/i2c/omap24xx_i2c.c
> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>
> return 0;
> }
> +
> +int i2c_get_bus_num(void)
> +{
> + return (int) current_bus;
> +}
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index a8abb0e..4d516a4 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -100,6 +100,12 @@
> /* DDR - I use Micron DDR */
> #define CONFIG_OMAP3_MICRON_DDR 1
>
> +/* Enable Multi Bus support for I2C */
> +#define CONFIG_I2C_MULTI_BUS 1
> +
> +/* Probe all devices */
> +#define CONFIG_SYS_I2C_NOPROBES {0x0, 0x0}
Most/All of the configs I reviewed set the addr element
to a valid address. I do not believe 0 is a valid address
on omap. If the intent is a double negative
{0, 0} == probe all
Then add a comment.
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
2010-01-24 0:05 ` Tom
@ 2010-01-25 14:10 ` Khasim Syed Mohammed
2010-01-25 15:07 ` Tom
2010-02-06 7:30 ` Dirk Behme
1 sibling, 1 reply; 8+ messages in thread
From: Khasim Syed Mohammed @ 2010-01-25 14:10 UTC (permalink / raw)
To: u-boot
On Sun, Jan 24, 2010 at 5:35 AM, Tom <Tom.Rix@windriver.com> wrote:
> Khasim Syed Mohammed wrote:
>>
>> From 9bb1c3501c8f098dac6e224c99e409ebf92b0ab9 Mon Sep 17 00:00:00 2001
>> From: Syed Mohammed Khasim <khasim@ti.com>
>> Date: Mon, 18 Jan 2010 18:11:14 +0530
>> Subject: [PATCH] Enable I2C bus switching
>>
>> OMAP3 supports Multiple I2C channels, this patch allows
>> us to use i2c dev <bus no> command to switch between busses.
>>
>> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
>> Acked-by: Heiko Schocher <hs@denx.de>
>> ---
>> ?drivers/i2c/omap24xx_i2c.c ? ? | ? ?5 +++++
>> ?include/configs/omap3_beagle.h | ? ?6 ++++++
>> ?2 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
>> index ff18991..e8c8184 100644
>> --- a/drivers/i2c/omap24xx_i2c.c
>> +++ b/drivers/i2c/omap24xx_i2c.c
>> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>>
>> ? ? ? ?return 0;
>> ?}
>> +
>> +int i2c_get_bus_num(void)
>> +{
>> + ? ? ? return (int) current_bus;
>> +}
>> diff --git a/include/configs/omap3_beagle.h
>> b/include/configs/omap3_beagle.h
>> index a8abb0e..4d516a4 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -100,6 +100,12 @@
>> ?/* DDR - I use Micron DDR */
>> ?#define CONFIG_OMAP3_MICRON_DDR ? ? ? ? ? ? ? ?1
>>
>> +/* Enable Multi Bus support for I2C */
>> +#define CONFIG_I2C_MULTI_BUS ? ? ? ? ? 1
>> +
>> +/* Probe all devices */
>> +#define CONFIG_SYS_I2C_NOPROBES ? ? ? ? ? ? ? ?{0x0, 0x0}
>
> Most/All of the configs I reviewed set the addr element
> to a valid address. ?I do not believe 0 is a valid address
> on omap. ?If the intent is a double negative
> {0, 0} == probe all
> Then add a comment.
>
I thought I already added a comment ,
>> +/* Probe all devices */
What more are you expecting. please print ...
Regards,
Khasim
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
2010-01-25 14:10 ` Khasim Syed Mohammed
@ 2010-01-25 15:07 ` Tom
0 siblings, 0 replies; 8+ messages in thread
From: Tom @ 2010-01-25 15:07 UTC (permalink / raw)
To: u-boot
Khasim Syed Mohammed wrote:
> On Sun, Jan 24, 2010 at 5:35 AM, Tom <Tom.Rix@windriver.com> wrote:
>> Khasim Syed Mohammed wrote:
>>> From 9bb1c3501c8f098dac6e224c99e409ebf92b0ab9 Mon Sep 17 00:00:00 2001
>>> From: Syed Mohammed Khasim <khasim@ti.com>
>>> Date: Mon, 18 Jan 2010 18:11:14 +0530
>>> Subject: [PATCH] Enable I2C bus switching
>>>
>>> OMAP3 supports Multiple I2C channels, this patch allows
>>> us to use i2c dev <bus no> command to switch between busses.
>>>
>>> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
>>> Acked-by: Heiko Schocher <hs@denx.de>
>>> ---
>>> drivers/i2c/omap24xx_i2c.c | 5 +++++
>>> include/configs/omap3_beagle.h | 6 ++++++
>>> 2 files changed, 11 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
>>> index ff18991..e8c8184 100644
>>> --- a/drivers/i2c/omap24xx_i2c.c
>>> +++ b/drivers/i2c/omap24xx_i2c.c
>>> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>>>
>>> return 0;
>>> }
>>> +
>>> +int i2c_get_bus_num(void)
>>> +{
>>> + return (int) current_bus;
>>> +}
>>> diff --git a/include/configs/omap3_beagle.h
>>> b/include/configs/omap3_beagle.h
>>> index a8abb0e..4d516a4 100644
>>> --- a/include/configs/omap3_beagle.h
>>> +++ b/include/configs/omap3_beagle.h
>>> @@ -100,6 +100,12 @@
>>> /* DDR - I use Micron DDR */
>>> #define CONFIG_OMAP3_MICRON_DDR 1
>>>
>>> +/* Enable Multi Bus support for I2C */
>>> +#define CONFIG_I2C_MULTI_BUS 1
>>> +
>>> +/* Probe all devices */
>>> +#define CONFIG_SYS_I2C_NOPROBES {0x0, 0x0}
>> Most/All of the configs I reviewed set the addr element
>> to a valid address. I do not believe 0 is a valid address
>> on omap. If the intent is a double negative
>> {0, 0} == probe all
>> Then add a comment.
>>
> I thought I already added a comment ,
>
>>> +/* Probe all devices */
> What more are you expecting. please print ...
Sorry.
I missed that.
This is fine.
Tom
>
> Regards,
> Khasim
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
2010-01-24 0:05 ` Tom
2010-01-25 14:10 ` Khasim Syed Mohammed
@ 2010-02-06 7:30 ` Dirk Behme
2010-02-07 6:32 ` Ben Warren
1 sibling, 1 reply; 8+ messages in thread
From: Dirk Behme @ 2010-02-06 7:30 UTC (permalink / raw)
To: u-boot
On 24.01.2010 01:05, Tom wrote:
> Khasim Syed Mohammed wrote:
>> From 9bb1c3501c8f098dac6e224c99e409ebf92b0ab9 Mon Sep 17 00:00:00 2001
>> From: Syed Mohammed Khasim<khasim@ti.com>
>> Date: Mon, 18 Jan 2010 18:11:14 +0530
>> Subject: [PATCH] Enable I2C bus switching
>>
>> OMAP3 supports Multiple I2C channels, this patch allows
>> us to use i2c dev<bus no> command to switch between busses.
>>
>> Signed-off-by: Syed Mohammed Khasim<khasim@ti.com>
>> Acked-by: Heiko Schocher<hs@denx.de>
>> ---
>> drivers/i2c/omap24xx_i2c.c | 5 +++++
>> include/configs/omap3_beagle.h | 6 ++++++
>> 2 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
>> index ff18991..e8c8184 100644
>> --- a/drivers/i2c/omap24xx_i2c.c
>> +++ b/drivers/i2c/omap24xx_i2c.c
>> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>>
>> return 0;
>> }
>> +
>> +int i2c_get_bus_num(void)
>> +{
>> + return (int) current_bus;
>> +}
>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>> index a8abb0e..4d516a4 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -100,6 +100,12 @@
>> /* DDR - I use Micron DDR */
>> #define CONFIG_OMAP3_MICRON_DDR 1
>>
>> +/* Enable Multi Bus support for I2C */
>> +#define CONFIG_I2C_MULTI_BUS 1
>> +
>> +/* Probe all devices */
>> +#define CONFIG_SYS_I2C_NOPROBES {0x0, 0x0}
>
> Most/All of the configs I reviewed set the addr element
> to a valid address. I do not believe 0 is a valid address
> on omap. If the intent is a double negative
> {0, 0} == probe all
> Then add a comment.
I would fix this, but I have no idea what to add :( Any hint?
Dirk
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching
2010-02-06 7:30 ` Dirk Behme
@ 2010-02-07 6:32 ` Ben Warren
0 siblings, 0 replies; 8+ messages in thread
From: Ben Warren @ 2010-02-07 6:32 UTC (permalink / raw)
To: u-boot
Dirk,
On 2/5/2010 11:30 PM, Dirk Behme wrote:
> On 24.01.2010 01:05, Tom wrote:
>
>> Khasim Syed Mohammed wrote:
>>
>>> From 9bb1c3501c8f098dac6e224c99e409ebf92b0ab9 Mon Sep 17 00:00:00 2001
>>> From: Syed Mohammed Khasim<khasim@ti.com>
>>> Date: Mon, 18 Jan 2010 18:11:14 +0530
>>> Subject: [PATCH] Enable I2C bus switching
>>>
>>> OMAP3 supports Multiple I2C channels, this patch allows
>>> us to use i2c dev<bus no> command to switch between busses.
>>>
>>> Signed-off-by: Syed Mohammed Khasim<khasim@ti.com>
>>> Acked-by: Heiko Schocher<hs@denx.de>
>>> ---
>>> drivers/i2c/omap24xx_i2c.c | 5 +++++
>>> include/configs/omap3_beagle.h | 6 ++++++
>>> 2 files changed, 11 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c
>>> index ff18991..e8c8184 100644
>>> --- a/drivers/i2c/omap24xx_i2c.c
>>> +++ b/drivers/i2c/omap24xx_i2c.c
>>> @@ -435,3 +435,8 @@ int i2c_set_bus_num(unsigned int bus)
>>>
>>> return 0;
>>> }
>>> +
>>> +int i2c_get_bus_num(void)
>>> +{
>>> + return (int) current_bus;
>>> +}
>>> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
>>> index a8abb0e..4d516a4 100644
>>> --- a/include/configs/omap3_beagle.h
>>> +++ b/include/configs/omap3_beagle.h
>>> @@ -100,6 +100,12 @@
>>> /* DDR - I use Micron DDR */
>>> #define CONFIG_OMAP3_MICRON_DDR 1
>>>
>>> +/* Enable Multi Bus support for I2C */
>>> +#define CONFIG_I2C_MULTI_BUS 1
>>> +
>>> +/* Probe all devices */
>>> +#define CONFIG_SYS_I2C_NOPROBES {0x0, 0x0}
>>>
>> Most/All of the configs I reviewed set the addr element
>> to a valid address. I do not believe 0 is a valid address
>> on omap. If the intent is a double negative
>> {0, 0} == probe all
>> Then add a comment.
>>
> I would fix this, but I have no idea what to add :( Any hint?
>
>
CONFIG_SYS_I2C_NOPROBES doesn't have to be defined. It's there as a
convenience in case there are devices that you don't want to be included
when probing the bus. If there's nothing you want to skip, don't define it.
> Dirk
> _____
>
regards,
Ben
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-02-07 6:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-12 19:02 [U-Boot] TI:OMAP: [PATCH 2/7] Enable I2C bus switching Khasim Syed Mohammed
2010-01-17 0:19 ` Tom
-- strict thread matches above, loose matches on Subject: below --
2010-01-18 13:55 Khasim Syed Mohammed
2010-01-24 0:05 ` Tom
2010-01-25 14:10 ` Khasim Syed Mohammed
2010-01-25 15:07 ` Tom
2010-02-06 7:30 ` Dirk Behme
2010-02-07 6:32 ` Ben Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.