From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] switch from sprintf to asprintf and snprintf
Date: Sun, 17 Jan 2010 13:02:55 +0100 [thread overview]
Message-ID: <4B52FC6F.5060100@gmail.com> (raw)
In-Reply-To: <20100101115256.GG3692@thorin>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Robert Millan wrote:
> On Fri, Jan 01, 2010 at 09:32:24AM +0000, Colin Watson wrote:
>
>> On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>
>>> +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...)
>>> + __attribute__ ((format (printf, 1, 2)));
>>>
>> It's very confusing that you've made grub_asprintf have a dramatically
>> different interface from asprintf. Perhaps you could call this
>> grub_xasprintf instead?
>>
>
> Is it feasible to implement the same interface as asprintf instead?
>
>
it's feasible but the only advantage it gives is the return value nobody
uses anyway
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
next prev parent reply other threads:[~2010-01-17 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 9:30 [PATCH] switch from sprintf to asprintf and snprintf Vladimir 'φ-coder/phcoder' Serbinenko
2010-01-01 9:32 ` Colin Watson
2010-01-01 11:52 ` Robert Millan
2010-01-01 12:01 ` Colin Watson
2010-01-17 12:02 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2010-01-19 22:29 ` Robert Millan
2010-01-19 22:56 ` Colin Watson
2010-01-19 23:16 ` Robert Millan
2010-01-17 11:59 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-01-01 11:51 ` Robert Millan
2010-01-17 12:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B52FC6F.5060100@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.