From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
KVM General <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/6] KVM: PPC: FPU/Altivec/VSX bringup
Date: Sun, 17 Jan 2010 12:33:21 +0000 [thread overview]
Message-ID: <4B530391.6000701@redhat.com> (raw)
In-Reply-To: <1263563354-11075-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
On 01/15/2010 03:49 PM, Alexander Graf wrote:
> Right now the code to use external providers (FPU/Altivec/FSX) is rather hacky.
>
> We just set the respective feature bit in the guest MSR when the guest requests
> it and declare it as good. Now, Linux wants to mess around there too, so
> whenever a process switch occurs, it saves the external provider state and
> reloads the current thread ones'.
>
> Unfortunately, we didn't tell Linux about our guest state. So Linux doesn't even
> get the chance to swap any of our registers around which means it ends up
> restoring registers from random processes - and we lose all state.
>
> This patchset makes at least FPU and Altivec work. I don't have a VSX machine to
> test that extension on. While at it, it also fixes some issues I've stumbled
> across during debug.
>
> The basic ideas on how this should work come from Benjamin Herrenschmidt.
> Thanks a lot for giving input on this one (and all the other times)!
>
Applied all, thanks.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
KVM General <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/6] KVM: PPC: FPU/Altivec/VSX bringup
Date: Sun, 17 Jan 2010 14:33:21 +0200 [thread overview]
Message-ID: <4B530391.6000701@redhat.com> (raw)
In-Reply-To: <1263563354-11075-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
On 01/15/2010 03:49 PM, Alexander Graf wrote:
> Right now the code to use external providers (FPU/Altivec/FSX) is rather hacky.
>
> We just set the respective feature bit in the guest MSR when the guest requests
> it and declare it as good. Now, Linux wants to mess around there too, so
> whenever a process switch occurs, it saves the external provider state and
> reloads the current thread ones'.
>
> Unfortunately, we didn't tell Linux about our guest state. So Linux doesn't even
> get the chance to swap any of our registers around which means it ends up
> restoring registers from random processes - and we lose all state.
>
> This patchset makes at least FPU and Altivec work. I don't have a VSX machine to
> test that extension on. While at it, it also fixes some issues I've stumbled
> across during debug.
>
> The basic ideas on how this should work come from Benjamin Herrenschmidt.
> Thanks a lot for giving input on this one (and all the other times)!
>
Applied all, thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-01-17 12:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 13:49 [PATCH 0/6] KVM: PPC: FPU/Altivec/VSX bringup Alexander Graf
2010-01-15 13:49 ` Alexander Graf
2010-01-15 13:49 ` [PATCH 2/6] KVM: PPC: Add helper functions to call real mode loaders Alexander Graf
2010-01-15 13:49 ` Alexander Graf
2010-01-15 13:49 ` [PATCH 5/6] KVM: PPC: Keep SRR1 flags around in shadow_msr Alexander Graf
2010-01-15 13:49 ` Alexander Graf
[not found] ` <1263563354-11075-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-01-15 13:49 ` [PATCH 1/6] KVM: PPC: Export __giveup_vsx Alexander Graf
2010-01-15 13:49 ` Alexander Graf
2010-01-15 13:49 ` [PATCH 3/6] KVM: PPC: Add support for FPU/Altivec/VSX Alexander Graf
2010-01-15 13:49 ` Alexander Graf
2010-01-15 13:49 ` [PATCH 4/6] KVM: PPC: Fix initial GPR settings Alexander Graf
2010-01-15 13:49 ` Alexander Graf
2010-01-15 13:49 ` [PATCH 6/6] KVM: PPC: Move Shadow MSR calculation to function Alexander Graf
2010-01-15 13:49 ` Alexander Graf
2010-01-17 12:33 ` Avi Kivity [this message]
2010-01-17 12:33 ` [PATCH 0/6] KVM: PPC: FPU/Altivec/VSX bringup Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B530391.6000701@redhat.com \
--to=avi@redhat.com \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.