* [PATCH] checkpatch.pl: Extend list of expected-to-be-const structures
@ 2010-01-17 16:43 Emese Revfy
0 siblings, 0 replies; only message in thread
From: Emese Revfy @ 2010-01-17 16:43 UTC (permalink / raw)
To: linux-kernel, apw, akpm, dwalker, Arjan van de Ven, Pavel Machek,
torvalds
From: Emese Revfy <re.emese@gmail.com>
Based on Arjan's suggestion, extend the list of ops structures that should be const.
Signed-off-by: Emese Revfy <re.emese@gmail.com>
--
scripts/checkpatch.pl | 43 ++++++++++++++++++++++++++++++++++++++++---
1 file changed, 40 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3257d3d..9494433 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2634,9 +2634,46 @@ sub process {
if ($line =~ /^.\s*__initcall\s*\(/) {
WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
}
-# check for struct file_operations, ensure they are const.
+# check for various ops structs, ensure they are const.
+ my $struct_ops = qr{acpi_dock_ops|
+ address_space_operations|
+ backlight_ops|
+ block_device_operations|
+ dentry_operations|
+ dev_pm_ops|
+ dma_map_ops|
+ extent_io_ops|
+ file_lock_operations|
+ file_operations|
+ hv_ops|
+ ide_dma_ops|
+ intel_dvo_dev_ops|
+ item_operations|
+ iwl_ops|
+ kgdb_arch|
+ kgdb_io|
+ kset_uevent_ops|
+ lock_manager_operations|
+ microcode_ops|
+ mtrr_ops|
+ neigh_ops|
+ nlmsvc_binding|
+ pci_raw_ops|
+ pipe_buf_operations|
+ platform_hibernation_ops|
+ platform_suspend_ops|
+ proto_ops|
+ rpc_pipe_ops|
+ seq_operations|
+ snd_ac97_build_ops|
+ soc_pcmcia_socket_ops|
+ stacktrace_ops|
+ sysfs_ops|
+ tty_operations|
+ usb_mon_operations|
+ wd_ops}x;
if ($line !~ /\bconst\b/ &&
- $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
+ $line =~ /\bstruct\s+($struct_ops)\b/) {
WARN("struct $1 should normally be const\n" .
$herecurr);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-17 16:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-17 16:43 [PATCH] checkpatch.pl: Extend list of expected-to-be-const structures Emese Revfy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.