Re: [PATCH] barebox: Add recipe for this new bootloader

[Mike Westerhof <mike@mwester.net>]

Frans Meulenbroeks wrote:
> 2010/1/17 Paul Menzel <paulepanter@users.sourceforge.net>:
>> Am Sonntag, den 17.01.2010, 22:02 +0100 schrieb Koen Kooi:

>>> Please don't set variables to the current default value, but leave
>>> them
>>> out. We had tons of problems with vars getting copy/paste where the
>>> default changed and we had to manually fix those (e.g. efl.bbclass
>>> still
>>> pokes needlessly at PACKAGES).
>>>
>>> Setting PR is relatively minor, but lets stay consistent :)
>> Could someone please change this in the manual please [1].
>>
>> »It is good practice to always define PR in your recipes, even for the
>> "r0" release, so that when editing the recipe it is clear that the PR
>> number needs to be updated.«
>>
> Personally I'm in favour of the above good practice.
> I suggest to keep PR = "r0" in recipes
> 
> Frans

+1 on this.   The PR is such a common variable to set, and as Koen
observes setting it to zero is relatively minor.  I feel that its
presence in a recipe may help avoid the "forgot to bump PR" problems.

-Mike (mwester)