From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Nathan Baum <nathan@parenthephobia.org.uk>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC, PATCH 10/11] qdev: Add do_info_qbus and friends.
Date: Mon, 18 Jan 2010 13:59:14 +0100 [thread overview]
Message-ID: <4B545B22.5080605@redhat.com> (raw)
In-Reply-To: <m3ska31tit.fsf@blackfin.pond.sub.org>
On 01/18/10 13:34, Markus Armbruster wrote:
>>> However, because there are both device properties and bus properties
>>> (really: device properties common to all devices on this bus), their
>>> names can clash. Device properties take precedence (see
>>> qdev_prop_find()). Hmm, qdev_printf() prints even overridden bus
>>> properties, not sure that's appropriate. Gerd?
>>
>> IMHO they must not clash. This isn't enforced in any way though.
>
> If they must not clash, then it makes no sense to invent a fancy prefix
> to cope with clashes, I think.
I've added the bus- and dev- prefixes to make clear where the properties
come from (BusInfo or DeviceInfo) for informational purposes, not to
avoid clashes. We could just drop that ...
> Alternatively, we could declare devices overriding properties inherited
> from the bus a feature.
No, this is just asking for trouble IMHO.
cheers,
Gerd
next prev parent reply other threads:[~2010-01-18 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1261861899-1984-1-git-send-email-nathan@parenthephobia.org.uk>
[not found] ` <1261861899-1984-5-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:06 ` [Qemu-devel] [RFC,PATCH 04/11] qdev: pcibus_dev_info Markus Armbruster
[not found] ` <1261861899-1984-9-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:14 ` [Qemu-devel] [RFC,PATCH 08/11] qdev: Add usb_bus_dev_info Markus Armbruster
2010-01-15 22:14 ` Nathan Baum
2010-01-18 10:15 ` Markus Armbruster
2010-01-18 10:35 ` Gerd Hoffmann
2010-01-18 12:44 ` Markus Armbruster
[not found] ` <1261861899-1984-7-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:17 ` [Qemu-devel] [RFC,PATCH 06/11] qdev: sysbus_dev_info Markus Armbruster
[not found] ` <1261861899-1984-11-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:30 ` [Qemu-devel] [RFC, PATCH 10/11] qdev: Add do_info_qbus and friends Markus Armbruster
2010-01-18 10:37 ` Gerd Hoffmann
2010-01-18 12:34 ` Markus Armbruster
2010-01-18 12:59 ` Gerd Hoffmann [this message]
2010-01-15 18:31 ` [Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B545B22.5080605@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=nathan@parenthephobia.org.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.