All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Nathan Baum <nathan@parenthephobia.org.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC,PATCH 00/11] Half-convert info qtree to QMP.
Date: Fri, 15 Jan 2010 19:31:24 +0100	[thread overview]
Message-ID: <m3pr5bdxtv.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1261861899-1984-1-git-send-email-nathan@parenthephobia.org.uk> (Nathan Baum's message of "Sat, 26 Dec 2009 21:11:28 +0000")

Nathan Baum <nathan@parenthephobia.org.uk> writes:

> Hullo.
>
> This series of patches partially converts info qtree to QMP.
>
> I've gone halfway: one can use query-qtree in QMP.
>
> I haven't converted the old monitor function other than to rename it;
> do_info_qtree_print just ignores the QObject it is passed and prints
> the qtree the old-fashioned way.
>
>  hw/isa-bus.c |   19 +++++++++++++
>  hw/pci.c     |   50 +++++++++++++++++++++++++++++++++++
>  hw/qdev.c    |   82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  hw/qdev.h    |    5 +++-
>  hw/sysbus.c  |   20 ++++++++++++++
>  hw/usb-bus.c |   15 ++++++++++
>  monitor.c    |    3 +-
>  7 files changed, 191 insertions(+), 3 deletions(-)

Patch 2 adds a static function, patch 3 puts it to use.  Not bisectable
with -Werror.  Merge the two.  Same for patch 4+5, 6+7, 8+9, 10+11.

Completing the job shouldn't be hard, just change the print_dev methods
to format the value returned by the info_dev method instead of getting
the information out of the device.

Thanks!

      parent reply	other threads:[~2010-01-15 18:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1261861899-1984-1-git-send-email-nathan@parenthephobia.org.uk>
     [not found] ` <1261861899-1984-5-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:06   ` [Qemu-devel] [RFC,PATCH 04/11] qdev: pcibus_dev_info Markus Armbruster
     [not found] ` <1261861899-1984-9-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:14   ` [Qemu-devel] [RFC,PATCH 08/11] qdev: Add usb_bus_dev_info Markus Armbruster
2010-01-15 22:14     ` Nathan Baum
2010-01-18 10:15       ` Markus Armbruster
2010-01-18 10:35         ` Gerd Hoffmann
2010-01-18 12:44           ` Markus Armbruster
     [not found] ` <1261861899-1984-7-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:17   ` [Qemu-devel] [RFC,PATCH 06/11] qdev: sysbus_dev_info Markus Armbruster
     [not found] ` <1261861899-1984-11-git-send-email-nathan@parenthephobia.org.uk>
2010-01-15 18:30   ` [Qemu-devel] [RFC, PATCH 10/11] qdev: Add do_info_qbus and friends Markus Armbruster
2010-01-18 10:37     ` Gerd Hoffmann
2010-01-18 12:34       ` Markus Armbruster
2010-01-18 12:59         ` Gerd Hoffmann
2010-01-15 18:31 ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pr5bdxtv.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=nathan@parenthephobia.org.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.