Re: [PATCH 2/2] st: don't assert on empty fragment program

[Brian Paul <brianp@vmware.com>]

Luca Barbieri wrote:
> Sauerbraten triggers this assert.
> ---
>  src/mesa/state_tracker/st_atom_shader.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/state_tracker/st_atom_shader.c
> index 176f3ea..fce533a 100644
> --- a/src/mesa/state_tracker/st_atom_shader.c
> +++ b/src/mesa/state_tracker/st_atom_shader.c
> @@ -79,8 +79,6 @@ translate_fp(struct st_context *st,
>  
>        stfp->num_input_slots = numIn;
>  
> -      assert(stfp->Base.Base.NumInstructions > 1);
> -
>        st_translate_fragment_program(st, stfp, stfp->input_to_slot);
>     }
>  }

How do we end up with a shader that has only one instruction (or 
none)?  Is it an END instruction?  I'd like to learn more about what's 
happening before committing this.

-Brian


------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev