All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Paul <brianp@vmware.com>
To: Luca Barbieri <luca@luca-barbieri.com>
Cc: "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"mesa3d-dev@lists.sourceforge.net"
	<mesa3d-dev@lists.sourceforge.net>
Subject: Re: [PATCH 2/2] st: don't assert on empty fragment program
Date: Mon, 18 Jan 2010 11:26:14 -0700	[thread overview]
Message-ID: <4B54A7C6.4060402@vmware.com> (raw)
In-Reply-To: <ff13bc9a1001181015u4943a6edm4098145a12e72804@mail.gmail.com>

Luca Barbieri wrote:
> Breakpoint 3, _mesa_ProgramStringARB (target=34820, format=34933,
> len=70, string=0x85922ba) at shader/arbprogram.c:434
> 434	   GET_CURRENT_CONTEXT(ctx);
> $31 = 0x85922ba "!!ARBfp1.0\n    \n    OPTION
> ARB_precision_hint_fastest;\n    \n\n\n    END\n"
> 
> Not sure why Sauerbraten does this, but it does, at least on my system
> (Ubuntu Karmic, nv40 driver) and it should be legal.

OK, GL_ARB_fragment_programs says a fragment program does not have to 
write a color result (so the color is undefined).

But the assertion should be changed to "num instructions > 0" and not 
removed.  I'll fix that.

-Brian


------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev

  reply	other threads:[~2010-01-18 18:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-17 21:35 [PATCH 1/2] nv40: don't crash on empty fragment program Luca Barbieri
     [not found] ` <1263764160-8891-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
2010-01-17 21:36   ` [PATCH 2/2] st: don't assert " Luca Barbieri
2010-01-18 18:01     ` Brian Paul
     [not found]       ` <4B54A208.10803-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2010-01-18 18:15         ` [Mesa3d-dev] " Luca Barbieri
2010-01-18 18:26           ` Brian Paul [this message]
     [not found]             ` <4B54A7C6.4060402-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2010-01-18 18:30               ` Luca Barbieri
2010-01-18 18:27           ` Roland Scheidegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B54A7C6.4060402@vmware.com \
    --to=brianp@vmware.com \
    --cc=luca@luca-barbieri.com \
    --cc=mesa3d-dev@lists.sourceforge.net \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.