* [PATCH] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit()
@ 2010-01-19 19:59 Roel Kluin
2010-01-21 2:04 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-19 19:59 UTC (permalink / raw)
To: Henrique de Moraes Holschuh, ibm-acpi-devel, Andrew Morton, LKML
sysfs_remove_group() removed the wrong attribute_group for
thermal_read_mode TPEC_8, ACPI_TMP07 and ACPI_UPDT
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Was this maybe intended? otherwise in case TPACPI_THERMAL_TPEC_16:
the same code is executed. Please review.
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index e67e4fe..eb603f1 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5771,7 +5771,7 @@ static void thermal_exit(void)
case TPACPI_THERMAL_ACPI_TMP07:
case TPACPI_THERMAL_ACPI_UPDT:
sysfs_remove_group(&tpacpi_sensors_pdev->dev.kobj,
- &thermal_temp_input16_group);
+ &thermal_temp_input8_group);
break;
case TPACPI_THERMAL_NONE:
default:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit()
2010-01-19 19:59 [PATCH] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit() Roel Kluin
@ 2010-01-21 2:04 ` Henrique de Moraes Holschuh
0 siblings, 0 replies; 2+ messages in thread
From: Henrique de Moraes Holschuh @ 2010-01-21 2:04 UTC (permalink / raw)
To: Roel Kluin; +Cc: ibm-acpi-devel, Andrew Morton, LKML
On Tue, 19 Jan 2010, Roel Kluin wrote:
> sysfs_remove_group() removed the wrong attribute_group for
> thermal_read_mode TPEC_8, ACPI_TMP07 and ACPI_UPDT
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
I will queue it.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-21 2:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 19:59 [PATCH] thinkpad-acpi: wrong thermal attribute_group removed in thermal_exit() Roel Kluin
2010-01-21 2:04 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.