* [PATCH] ath9k: fix beacon slot/buffer leak
@ 2010-01-19 19:51 Felix Fietkau
2010-01-19 21:06 ` Luis R. Rodriguez
0 siblings, 1 reply; 4+ messages in thread
From: Felix Fietkau @ 2010-01-19 19:51 UTC (permalink / raw)
To: linux-wireless; +Cc: Luis R. Rodriguez, John W. Linville
When cleaning up beacon buffers and slots, ath9k currently checks if
sc->ah->opmode is set to a beacon related mode before cleaning up
buffers.
An unfortunate ordering of interface up/down commands can lead to
sc->ah->opmode being set to monitor mode, while there are AP interfaces
present on the same wiphy.
Always cleaning up beacon buffers if present fixes this issue.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1471,10 +1471,10 @@ static void ath9k_remove_interface(struc
(sc->sc_ah->opmode == NL80211_IFTYPE_MESH_POINT)) {
ath9k_ps_wakeup(sc);
ath9k_hw_stoptxdma(sc->sc_ah, sc->beacon.beaconq);
- ath_beacon_return(sc, avp);
ath9k_ps_restore(sc);
}
+ ath_beacon_return(sc, avp);
sc->sc_flags &= ~SC_OP_BEACONS;
for (i = 0; i < ARRAY_SIZE(sc->beacon.bslot); i++) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ath9k: fix beacon slot/buffer leak
2010-01-19 19:51 [PATCH] ath9k: fix beacon slot/buffer leak Felix Fietkau
@ 2010-01-19 21:06 ` Luis R. Rodriguez
2010-01-19 21:19 ` Felix Fietkau
0 siblings, 1 reply; 4+ messages in thread
From: Luis R. Rodriguez @ 2010-01-19 21:06 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, John W. Linville
On Tue, Jan 19, 2010 at 11:51 AM, Felix Fietkau <nbd@openwrt.org> wrote:
> When cleaning up beacon buffers and slots, ath9k currently checks if
> sc->ah->opmode is set to a beacon related mode before cleaning up
> buffers.
> An unfortunate ordering of interface up/down commands can lead to
> sc->ah->opmode being set to monitor mode, while there are AP interfaces
> present on the same wiphy.
> Always cleaning up beacon buffers if present fixes this issue.
>
CC stable?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k: fix beacon slot/buffer leak
2010-01-19 21:06 ` Luis R. Rodriguez
@ 2010-01-19 21:19 ` Felix Fietkau
2010-01-19 21:35 ` Luis R. Rodriguez
0 siblings, 1 reply; 4+ messages in thread
From: Felix Fietkau @ 2010-01-19 21:19 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless, John W. Linville
On 2010-01-19 10:06 PM, Luis R. Rodriguez wrote:
> On Tue, Jan 19, 2010 at 11:51 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>> When cleaning up beacon buffers and slots, ath9k currently checks if
>> sc->ah->opmode is set to a beacon related mode before cleaning up
>> buffers.
>> An unfortunate ordering of interface up/down commands can lead to
>> sc->ah->opmode being set to monitor mode, while there are AP interfaces
>> present on the same wiphy.
>> Always cleaning up beacon buffers if present fixes this issue.
>>
>
> CC stable?
Yeah, forgot about that. Should I send it again with Cc?
- Felix
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k: fix beacon slot/buffer leak
2010-01-19 21:19 ` Felix Fietkau
@ 2010-01-19 21:35 ` Luis R. Rodriguez
0 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2010-01-19 21:35 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, John W. Linville
On Tue, Jan 19, 2010 at 1:19 PM, Felix Fietkau <nbd@openwrt.org> wrote:
> On 2010-01-19 10:06 PM, Luis R. Rodriguez wrote:
>> On Tue, Jan 19, 2010 at 11:51 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>>> When cleaning up beacon buffers and slots, ath9k currently checks if
>>> sc->ah->opmode is set to a beacon related mode before cleaning up
>>> buffers.
>>> An unfortunate ordering of interface up/down commands can lead to
>>> sc->ah->opmode being set to monitor mode, while there are AP interfaces
>>> present on the same wiphy.
>>> Always cleaning up beacon buffers if present fixes this issue.
>>>
>>
>> CC stable?
> Yeah, forgot about that. Should I send it again with Cc?
If John hasn't picked it up yet, sure.
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-19 21:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 19:51 [PATCH] ath9k: fix beacon slot/buffer leak Felix Fietkau
2010-01-19 21:06 ` Luis R. Rodriguez
2010-01-19 21:19 ` Felix Fietkau
2010-01-19 21:35 ` Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.