* [PATCH] Build fbv with JPEG and PNG enabled
@ 2010-01-19 23:06 Ulf Samuelsson
2010-01-19 23:25 ` Paul Menzel
0 siblings, 1 reply; 4+ messages in thread
From: Ulf Samuelsson @ 2010-01-19 23:06 UTC (permalink / raw)
To: openembedded-devel
Build fbv with jpeg and png enabled
Signed-off-by: Ulf Samuelsson <ulf.samuelsson@atmel.com>
---
recipes/fbv/fbv-1.0b/fbv-1.0b.patch | 12 ++++++++++++
recipes/fbv/fbv_1.0b.bb | 23 +++++++++++++++--------
2 files changed, 27 insertions(+), 8 deletions(-)
create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch
diff --git a/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
new file mode 100644
index 0000000..6fbd1fb
--- /dev/null
+++ b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
@@ -0,0 +1,12 @@
+diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile
+--- fbv-1.0b-0rig/Makefile 2009-08-20 00:33:58.000000000 +0200
++++ fbv-1.0b/Makefile 2009-08-20 00:34:16.000000000 +0200
+@@ -12,7 +12,7 @@
+ OBJECTS = ${SOURCES:.c=.o}
+
+ OUT = fbv
+-#LIBS = -lungif -L/usr/X11R6/lib -ljpeg -lpng
++LIBS = -L/usr/lib -ljpeg -lpng #-lungif
+
+ all: $(OUT)
+ @echo Build DONE.
diff --git a/recipes/fbv/fbv_1.0b.bb b/recipes/fbv/fbv_1.0b.bb
index 04c7066..4a5bd6b 100644
--- a/recipes/fbv/fbv_1.0b.bb
+++ b/recipes/fbv/fbv_1.0b.bb
@@ -1,25 +1,32 @@
DESCRIPTION = "Frame Buffer Viewer"
LICENSE = "GPL"
-DEPENDS = "libpng"
+DEPENDS = "libpng jpeg"
PR = "r1"
SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \
- file://cross_compile.patch;patch=1"
+ file://cross_compile.patch;patch=1 \
+ file://fbv-1.0b.patch;patch=1 \
+ "
+
+#inherit autotools
do_configure() {
- CC="${CC}" ./configure --without-libungif --without-bmp \
- --without-libjpeg
+ CC="${CC}" ./configure --without-libungif
}
do_compile() {
oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \
CC="${CC}"
}
+
do_install() {
install -d ${D}${bindir}
- install -m 0755 fbv ${D}${bindir}
+ install -m 0755 fbv ${D}${bindir}
- # man
- install -d ${D}${mandir}/man1/
- install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
+# man
+# install -d ${D}${mandir}/man1/
+# install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
}
+
+PACKAGES = "fbv"
+
--
1.6.0.2
--
Best Regards
Ulf Samuelsson
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Build fbv with JPEG and PNG enabled
2010-01-19 23:06 [PATCH] Build fbv with JPEG and PNG enabled Ulf Samuelsson
@ 2010-01-19 23:25 ` Paul Menzel
2010-01-19 23:28 ` Paul Menzel
0 siblings, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2010-01-19 23:25 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2609 bytes --]
Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
> Build fbv with jpeg and png enabled
>
> Signed-off-by: Ulf Samuelsson <ulf.samuelsson@atmel.com>
> ---
> recipes/fbv/fbv-1.0b/fbv-1.0b.patch | 12 ++++++++++++
> recipes/fbv/fbv_1.0b.bb | 23 +++++++++++++++--------
> 2 files changed, 27 insertions(+), 8 deletions(-)
> create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch
>
> diff --git a/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> new file mode 100644
> index 0000000..6fbd1fb
> --- /dev/null
> +++ b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> @@ -0,0 +1,12 @@
> +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile
> +--- fbv-1.0b-0rig/Makefile 2009-08-20 00:33:58.000000000 +0200
> ++++ fbv-1.0b/Makefile 2009-08-20 00:34:16.000000000 +0200
> +@@ -12,7 +12,7 @@
> + OBJECTS = ${SOURCES:.c=.o}
> +
> + OUT = fbv
> +-#LIBS = -lungif -L/usr/X11R6/lib -ljpeg -lpng
> ++LIBS = -L/usr/lib -ljpeg -lpng #-lungif
> +
> + all: $(OUT)
> + @echo Build DONE.
> diff --git a/recipes/fbv/fbv_1.0b.bb b/recipes/fbv/fbv_1.0b.bb
> index 04c7066..4a5bd6b 100644
> --- a/recipes/fbv/fbv_1.0b.bb
> +++ b/recipes/fbv/fbv_1.0b.bb
> @@ -1,25 +1,32 @@
> DESCRIPTION = "Frame Buffer Viewer"
> LICENSE = "GPL"
> -DEPENDS = "libpng"
> +DEPENDS = "libpng jpeg"
> PR = "r1"
Should not this be increased because of the changed `DEPENDS`? Why is
`PR` not just a number?
> SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \
> - file://cross_compile.patch;patch=1"
> + file://cross_compile.patch;patch=1 \
> + file://fbv-1.0b.patch;patch=1 \
> + "
> +
> +#inherit autotools
Please do not comment out code. Everything is under versioning control.
> do_configure() {
> - CC="${CC}" ./configure --without-libungif --without-bmp \
> - --without-libjpeg
> + CC="${CC}" ./configure --without-libungif
> }
>
> do_compile() {
> oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \
> CC="${CC}"
> }
> +
> do_install() {
> install -d ${D}${bindir}
> - install -m 0755 fbv ${D}${bindir}
> + install -m 0755 fbv ${D}${bindir}
What changed?
> - # man
> - install -d ${D}${mandir}/man1/
> - install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> +# man
> +# install -d ${D}${mandir}/man1/
> +# install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> }
Why did you disable this? If it is not needed, please do it in a
separate patch or at least mention it in the commit message.
> +
> +PACKAGES = "fbv"
> +
Thanks,
Paul
[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Build fbv with JPEG and PNG enabled
2010-01-19 23:25 ` Paul Menzel
@ 2010-01-19 23:28 ` Paul Menzel
2010-01-21 13:15 ` Phil Blundell
0 siblings, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2010-01-19 23:28 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3115 bytes --]
Am Mittwoch, den 20.01.2010, 00:25 +0100 schrieb Paul Menzel:
> Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
> > Build fbv with jpeg and png enabled
> >
> > Signed-off-by: Ulf Samuelsson <ulf.samuelsson@atmel.com>
> > ---
> > recipes/fbv/fbv-1.0b/fbv-1.0b.patch | 12 ++++++++++++
> > recipes/fbv/fbv_1.0b.bb | 23 +++++++++++++++--------
> > 2 files changed, 27 insertions(+), 8 deletions(-)
> > create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> >
> > diff --git a/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> > b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> > new file mode 100644
> > index 0000000..6fbd1fb
> > --- /dev/null
> > +++ b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> > @@ -0,0 +1,12 @@
> > +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile
> > +--- fbv-1.0b-0rig/Makefile 2009-08-20 00:33:58.000000000 +0200
> > ++++ fbv-1.0b/Makefile 2009-08-20 00:34:16.000000000 +0200
> > +@@ -12,7 +12,7 @@
> > + OBJECTS = ${SOURCES:.c=.o}
> > +
> > + OUT = fbv
> > +-#LIBS = -lungif -L/usr/X11R6/lib -ljpeg -lpng
> > ++LIBS = -L/usr/lib -ljpeg -lpng #-lungif
> > +
> > + all: $(OUT)
> > + @echo Build DONE.
> > diff --git a/recipes/fbv/fbv_1.0b.bb b/recipes/fbv/fbv_1.0b.bb
> > index 04c7066..4a5bd6b 100644
> > --- a/recipes/fbv/fbv_1.0b.bb
> > +++ b/recipes/fbv/fbv_1.0b.bb
> > @@ -1,25 +1,32 @@
> > DESCRIPTION = "Frame Buffer Viewer"
> > LICENSE = "GPL"
> > -DEPENDS = "libpng"
> > +DEPENDS = "libpng jpeg"
> > PR = "r1"
>
> Should not this be increased because of the changed `DEPENDS`? Why is
> `PR` not just a number?
Sorry, please ignore that second question. It is late!
> > SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \
> > - file://cross_compile.patch;patch=1"
> > + file://cross_compile.patch;patch=1 \
> > + file://fbv-1.0b.patch;patch=1 \
> > + "
> > +
> > +#inherit autotools
>
> Please do not comment out code. Everything is under versioning control.
>
> > do_configure() {
> > - CC="${CC}" ./configure --without-libungif --without-bmp \
> > - --without-libjpeg
> > + CC="${CC}" ./configure --without-libungif
> > }
> >
> > do_compile() {
> > oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \
> > CC="${CC}"
> > }
> > +
> > do_install() {
> > install -d ${D}${bindir}
> > - install -m 0755 fbv ${D}${bindir}
> > + install -m 0755 fbv ${D}${bindir}
>
> What changed?
>
> > - # man
> > - install -d ${D}${mandir}/man1/
> > - install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> > +# man
> > +# install -d ${D}${mandir}/man1/
> > +# install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> > }
>
> Why did you disable this? If it is not needed, please do it in a
> separate patch or at least mention it in the commit message.
>
> > +
> > +PACKAGES = "fbv"
> > +
>
>
> Thanks,
>
> Paul
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Build fbv with JPEG and PNG enabled
2010-01-19 23:28 ` Paul Menzel
@ 2010-01-21 13:15 ` Phil Blundell
0 siblings, 0 replies; 4+ messages in thread
From: Phil Blundell @ 2010-01-21 13:15 UTC (permalink / raw)
To: openembedded-devel
On Wed, 2010-01-20 at 00:28 +0100, Paul Menzel wrote:
> Am Mittwoch, den 20.01.2010, 00:25 +0100 schrieb Paul Menzel:
> > Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
> > > PR = "r1"
> >
> > Should not this be increased because of the changed `DEPENDS`? Why is
> > `PR` not just a number?
>
> Sorry, please ignore that second question. It is late!
That's actually a good question, though not one that's specific to this
one recipe. That leading "r" in ${PR} doesn't really serve any purpose
other than to make all the recipes one byte bigger, and it might be nice
to get rid of it at some point.
p.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-21 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 23:06 [PATCH] Build fbv with JPEG and PNG enabled Ulf Samuelsson
2010-01-19 23:25 ` Paul Menzel
2010-01-19 23:28 ` Paul Menzel
2010-01-21 13:15 ` Phil Blundell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.