All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 4/7] tabled: retry conflicting locks
Date: Wed, 20 Jan 2010 14:53:17 -0500	[thread overview]
Message-ID: <4B575F2D.3070403@garzik.org> (raw)
In-Reply-To: <20100114211312.2df3d349@redhat.com>

On 01/14/2010 11:13 PM, Pete Zaitcev wrote:
> This problem was with us for a while, and even with this fix our start-up
> is not reliable. But at least we will not be 100% guaranteed to hang as
> before when restarting too quickly. So although the whole area needs some
> serious reworking, this specific case was just too annoying to let it
> continue.
>
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
>   server/cldu.c |   38 ++++++++++++++++++++++++++++++++++----
>   1 file changed, 34 insertions(+), 4 deletions(-)

This is not correct.  CLD has blocking locks.  You issue the LOCK op, 
and will be notified when you have acquired the lock, possibly hours or 
days later.  There is no need to retry anything...

	Jeff



  reply	other threads:[~2010-01-20 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-15  4:13 [Patch 4/7] tabled: retry conflicting locks Pete Zaitcev
2010-01-20 19:53 ` Jeff Garzik [this message]
2010-01-20 20:16   ` Pete Zaitcev
2010-01-20 22:00     ` Jeff Garzik
2010-01-20 22:56       ` Pete Zaitcev
2010-02-03 23:10         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B575F2D.3070403@garzik.org \
    --to=jeff@garzik.org \
    --cc=hail-devel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.