From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
rade.bozic.ext-OYasijW0DpE@public.gmane.org,
ml.lawnick-Mmb7MZpHnFY@public.gmane.org
Subject: Re: [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports.
Date: Mon, 25 Jan 2010 10:19:14 -0800 [thread overview]
Message-ID: <4B5DE0A2.8070405@caviumnetworks.com> (raw)
In-Reply-To: <20100124160017.GF28675-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
Ben Dooks wrote:
> On Thu, Jan 07, 2010 at 11:54:20AM -0800, David Daney wrote:
>> From: Rade Bozic <rade.bozic.ext-OYasijW0DpE@public.gmane.org>
>>
>> Signed-off-by: Rade Bozic <rade.bozic.ext-OYasijW0DpE@public.gmane.org>
>> Signed-off-by: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
>> ---
>> drivers/i2c/busses/Kconfig | 10 +
>> drivers/i2c/busses/Makefile | 1 +
>> drivers/i2c/busses/i2c-octeon.c | 579 +++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 590 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/i2c/busses/i2c-octeon.c
[...]
>> +
>> +#ifndef NO_IRQ
>> +#define NO_IRQ (-1)
>> +#endif
>
> this does not fill me with a warm joyous feeling...
>
Indeed.
[ many other helpful comments deleted for brevity.]
We will improve the driver and resubmit.
Thanks for looking at it.
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
linux-i2c@vger.kernel.org, khali@linux-fr.org,
rade.bozic.ext@nsn.com, ml.lawnick@gmx.de
Subject: Re: [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports.
Date: Mon, 25 Jan 2010 10:19:14 -0800 [thread overview]
Message-ID: <4B5DE0A2.8070405@caviumnetworks.com> (raw)
In-Reply-To: <20100124160017.GF28675@fluff.org.uk>
Ben Dooks wrote:
> On Thu, Jan 07, 2010 at 11:54:20AM -0800, David Daney wrote:
>> From: Rade Bozic <rade.bozic.ext@nsn.com>
>>
>> Signed-off-by: Rade Bozic <rade.bozic.ext@nsn.com>
>> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
>> ---
>> drivers/i2c/busses/Kconfig | 10 +
>> drivers/i2c/busses/Makefile | 1 +
>> drivers/i2c/busses/i2c-octeon.c | 579 +++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 590 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/i2c/busses/i2c-octeon.c
[...]
>> +
>> +#ifndef NO_IRQ
>> +#define NO_IRQ (-1)
>> +#endif
>
> this does not fill me with a warm joyous feeling...
>
Indeed.
[ many other helpful comments deleted for brevity.]
We will improve the driver and resubmit.
Thanks for looking at it.
David Daney
next prev parent reply other threads:[~2010-01-25 18:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 19:50 [PATCH 0/3] Add I2C support for Octeon SOCs David Daney
2010-01-07 19:50 ` David Daney
[not found] ` <4B463B1F.6000404-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-01-07 19:54 ` [PATCH 1/3] MIPS: Octeon: Add I2C platform driver David Daney
2010-01-07 19:54 ` David Daney
[not found] ` <1262894061-32613-1-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-01-07 20:35 ` Sergei Shtylyov
2010-01-07 20:35 ` Sergei Shtylyov
[not found] ` <4B4645A3.30401-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-01-07 20:55 ` David Daney
2010-01-07 20:55 ` David Daney
2010-01-07 21:23 ` [PATCH 1/3] MIPS: Octeon: Add I2C platform device David Daney
2010-01-07 19:54 ` [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports David Daney
2010-01-07 19:54 ` David Daney
[not found] ` <1262894061-32613-2-git-send-email-ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-01-24 16:00 ` Ben Dooks
2010-01-24 16:00 ` Ben Dooks
2010-01-25 15:12 ` Bozic, Rade (EXT-Other - DE/Ulm)
2010-01-25 15:12 ` Bozic, Rade (EXT-Other - DE/Ulm)
[not found] ` <20100124160017.GF28675-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2010-01-25 11:55 ` Michael Lawnick
2010-01-25 11:55 ` Michael Lawnick
2010-01-25 18:19 ` David Daney [this message]
2010-01-25 18:19 ` David Daney
2010-01-07 19:54 ` [PATCH 3/3] MIPS: Octeon: Register some devices on the I2C bus David Daney
2010-01-07 19:54 ` David Daney
2010-01-07 19:56 ` [PATCH 0/3] Add I2C support for Octeon SOCs David Daney
2010-01-07 19:56 ` David Daney
[not found] ` <4B463C71.3080005-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-01-11 14:44 ` Ralf Baechle
2010-01-11 14:44 ` Ralf Baechle
[not found] ` <20100111144416.GA23157-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2010-01-11 17:16 ` David Daney
2010-01-11 17:16 ` David Daney
[not found] ` <4B4B5CD3.4040204-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-01-11 17:23 ` Jean Delvare
2010-01-11 17:23 ` Jean Delvare
2010-01-13 0:49 ` Markus Gothe
[not found] ` <F5F1F5D1-6057-49CF-A5B3-A921E1C0EEEB-SamgB31n2u5IcsJQ0EH25Q@public.gmane.org>
2010-01-13 9:29 ` Jean Delvare
2010-01-13 9:29 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5DE0A2.8070405@caviumnetworks.com \
--to=ddaney-m3mlkvoiwjvv6pq1l3v1odbpr1lh4cv8@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
--cc=rade.bozic.ext-OYasijW0DpE@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.