From: Ben Schmidt <mail_ben_schmidt@yahoo.com.au>
To: mlmmj@mlmmj.org
Subject: PATCH: Bugfix for subjectless listtext
Date: Tue, 26 Jan 2010 12:17:10 +0000 [thread overview]
Message-ID: <4B5EDD46.6050706@yahoo.com.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
I noticed this bug while perusing the code with the view to a future feature
implementation. If a listtext has no subject, the first line is taken to be part
of the listtext, but does not undergo substitution as it should. Probably rare for
it to be needed, but I think it's a bug that it isn't treated properly.
I have *NOT* tested this one. I have neither confirmed the bug is there, nor that
the patch fixes it. This is more a 'heads up' that you may like to review this
part of the code.
Ben.
[-- Attachment #2: mlmmj-fix-subjectless-listtext.patch --]
[-- Type: text/x-patch, Size: 428 bytes --]
diff -r f4d710c7dc54 -r c9510eaa0130 src/prepstdreply.c
--- a/src/prepstdreply.c Tue Jan 26 22:45:06 2010 +1100
+++ b/src/prepstdreply.c Tue Jan 26 23:14:28 2010 +1100
@@ -250,6 +250,10 @@
if (line) {
utfline = unistr_escaped_to_utf8(line);
myfree(line);
+ tmp = utfline;
+ str = substitute(utfline, listaddr, listdelim, tokencount, data, mailname);
+ myfree(tmp);
+ utfline = str;
} else {
utfline = NULL;
}
reply other threads:[~2010-01-26 12:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5EDD46.6050706@yahoo.com.au \
--to=mail_ben_schmidt@yahoo.com.au \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.