All of lore.kernel.org
 help / color / mirror / Atom feed
* PATCH: Bugfix for subjectless listtext
@ 2010-01-26 12:17 Ben Schmidt
  0 siblings, 0 replies; only message in thread
From: Ben Schmidt @ 2010-01-26 12:17 UTC (permalink / raw)
  To: mlmmj

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

I noticed this bug while perusing the code with the view to a future feature 
implementation. If a listtext has no subject, the first line is taken to be part 
of the listtext, but does not undergo substitution as it should. Probably rare for 
it to be needed, but I think it's a bug that it isn't treated properly.

I have *NOT* tested this one. I have neither confirmed the bug is there, nor that 
the patch fixes it. This is more a 'heads up' that you may like to review this 
part of the code.

Ben.



[-- Attachment #2: mlmmj-fix-subjectless-listtext.patch --]
[-- Type: text/x-patch, Size: 428 bytes --]

diff -r f4d710c7dc54 -r c9510eaa0130 src/prepstdreply.c
--- a/src/prepstdreply.c	Tue Jan 26 22:45:06 2010 +1100
+++ b/src/prepstdreply.c	Tue Jan 26 23:14:28 2010 +1100
@@ -250,6 +250,10 @@
 	if (line) {
 		utfline = unistr_escaped_to_utf8(line);
 		myfree(line);
+		tmp = utfline;
+		str = substitute(utfline, listaddr, listdelim, tokencount, data, mailname);
+		myfree(tmp);
+		utfline = str;
 	} else {
 		utfline = NULL;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-26 12:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-26 12:17 PATCH: Bugfix for subjectless listtext Ben Schmidt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.