From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs
Date: Tue, 26 Jan 2010 07:08:20 -0600 [thread overview]
Message-ID: <4B5EE944.9050602@codemonkey.ws> (raw)
In-Reply-To: <20100126092104.GA21528@lst.de>
On 01/26/2010 03:21 AM, Christoph Hellwig wrote:
> On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote:
>
>> To underline that it's a backend/platform dependent thing: Your patch
>> breaks the mingw build for me.
>>
> Actually that's because mingw is the usual piece of crap and doesn't
> actually have any of the vector support you can expect from a normal
> Unix system.
>
> I can either throw in an #ifdef IOV_MAX around the check or fake one up
> for mingw. Does any of the maintainers have a preference for either
> variant?
>
grep for CONFIG_IOVEC in qemu-common.h and add a #define IOV_MAX.
mingw doesn't have iovec so we introduce a compat version.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-26 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 21:15 [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs Christoph Hellwig
2010-01-20 11:37 ` Kevin Wolf
2010-01-20 16:24 ` Christoph Hellwig
2010-01-20 16:29 ` Kevin Wolf
2010-01-26 9:21 ` Christoph Hellwig
2010-01-26 13:08 ` Anthony Liguori [this message]
2010-01-26 13:42 ` Christoph Hellwig
2010-01-20 14:56 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5EE944.9050602@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.