From: Maurus Cuelenaere <mcuelenaere@gmail.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c
Date: Tue, 26 Jan 2010 17:02:49 +0100 [thread overview]
Message-ID: <4B5F1229.9030304@gmail.com> (raw)
In-Reply-To: <20100126145558.GE9153@trinity.fluff.org>
Op 26-01-10 15:55, Ben Dooks schreef:
> On Fri, Jan 22, 2010 at 11:47:11PM +0100, Maurus Cuelenaere wrote:
>
>> ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c
>>
>> Signed-off-by: Maurus Cuelenaere<mcuelenaere@gmail.com>
>>
> Renaming for naming sake is in my view just a waste of diff, unless
> anyone disagrees here.
>
Well I don't think it's pointless, having s3c24xx_ts_set_platdata() and
s3c2410_ts_mach_info instead of their s3c_ equivalents make it look like
the API only handles s3c24xx platforms, which isn't true (anymore).
But I can remove this commit, if you want to.
--
Maurus Cuelenaere
WARNING: multiple messages have this Message-ID (diff)
From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c
Date: Tue, 26 Jan 2010 17:02:49 +0100 [thread overview]
Message-ID: <4B5F1229.9030304@gmail.com> (raw)
In-Reply-To: <20100126145558.GE9153@trinity.fluff.org>
Op 26-01-10 15:55, Ben Dooks schreef:
> On Fri, Jan 22, 2010 at 11:47:11PM +0100, Maurus Cuelenaere wrote:
>
>> ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c
>>
>> Signed-off-by: Maurus Cuelenaere<mcuelenaere@gmail.com>
>>
> Renaming for naming sake is in my view just a waste of diff, unless
> anyone disagrees here.
>
Well I don't think it's pointless, having s3c24xx_ts_set_platdata() and
s3c2410_ts_mach_info instead of their s3c_ equivalents make it look like
the API only handles s3c24xx platforms, which isn't true (anymore).
But I can remove this commit, if you want to.
--
Maurus Cuelenaere
next prev parent reply other threads:[~2010-01-26 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 22:47 [PATCH 2/4] ARM: SAMSUNG: Rename s3c24xx touchscreen interface to s3c Maurus Cuelenaere
2010-01-22 22:47 ` Maurus Cuelenaere
2010-01-26 14:55 ` Ben Dooks
2010-01-26 14:55 ` Ben Dooks
2010-01-26 16:02 ` Maurus Cuelenaere [this message]
2010-01-26 16:02 ` Maurus Cuelenaere
2010-01-27 0:32 ` Maurus Cuelenaere
2010-01-27 0:32 ` Maurus Cuelenaere
2010-01-27 0:32 ` jassi brar
2010-01-27 0:32 ` jassi brar
2010-01-31 18:11 ` Pavel Machek
2010-01-31 18:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F1229.9030304@gmail.com \
--to=mcuelenaere@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.