All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>
Subject: Re: regression between 0.12.1.2 and 0.12.2
Date: Tue, 26 Jan 2010 17:21:06 +0100	[thread overview]
Message-ID: <4B5F1672.1040802@siemens.com> (raw)
In-Reply-To: <4B5A0C70.6020603@web.de>

Jan Kiszka wrote:
> Toralf Förster wrote:
>> Hi,
>>
>> under a mostly stable Gentoo I observed this new msg :
>>
>> tfoerste@n22 ~/virtual/kvm $ qemu -hda gentoo_kdevm.img -hdb portage_kdeprefix.img -hdd swap.img -smp 2 -m 768 -vga std -soundhw es1370                                                                                           
>> BUG: kvm_dirty_pages_log_enable_slot: invalid parameters                                                         
>> BUG: kvm_dirty_pages_log_disable_slot: invalid parameters                                                        
>> ..
>>
>> The kvm image can be derived from http://dev.gentooexperimental.org/~wired/kvm/ .
>>
>> My system is a :
>> tfoerste@n22 ~/virtual/kvm $ uname -a
>> Linux n22 2.6.32.4 #1 SMP Mon Jan 18 20:20:38 CET 2010 i686 Intel(R) Core(TM)2 Duo CPU P8600 @ 2.40GHz GenuineIntel GNU/Linux
>>
>>
> 
> That's a pre-0.12.1.2 qemu-kvm issue, upstream is not affected - or is
> at least not reporting it. It's already in my todo queue, just waiting
> to be dequeued.

I've looked into this a bit, and the bug message that pops up is in fact
new for your scenario (0.12.1.2->0.12.2, -vga std), it just happens to
trigger for me as well in a slightly different setup (CONFIG_FB_CIRRUS).

This is "mostly harmless" (the bug is gracefully handled), indicating
that qemu-kvm tries to enable/disable dirty logging for a VGA memory
area that was just unregistered. And that is because qemu-kvm tries to
keep support for old host kernels that had bugs and required workaround
approaches, but that code is bit-rotting a bit.

Avi, we should get rid of these messages, either by suppressing them in
qemu-kvm for now (stick your head into the sand...) or by finally
dropping all those dirty-logging diffs to upstream (in theory, there is
a third option: fixing the workaround code, but I don't think it's worth
the effort). What could be a road map for dropping? What distro kernels
are you aware of that may become unusable then?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: regression between 0.12.1.2 and 0.12.2
Date: Tue, 26 Jan 2010 17:21:06 +0100	[thread overview]
Message-ID: <4B5F1672.1040802@siemens.com> (raw)
In-Reply-To: <4B5A0C70.6020603@web.de>

Jan Kiszka wrote:
> Toralf Förster wrote:
>> Hi,
>>
>> under a mostly stable Gentoo I observed this new msg :
>>
>> tfoerste@n22 ~/virtual/kvm $ qemu -hda gentoo_kdevm.img -hdb portage_kdeprefix.img -hdd swap.img -smp 2 -m 768 -vga std -soundhw es1370                                                                                           
>> BUG: kvm_dirty_pages_log_enable_slot: invalid parameters                                                         
>> BUG: kvm_dirty_pages_log_disable_slot: invalid parameters                                                        
>> ..
>>
>> The kvm image can be derived from http://dev.gentooexperimental.org/~wired/kvm/ .
>>
>> My system is a :
>> tfoerste@n22 ~/virtual/kvm $ uname -a
>> Linux n22 2.6.32.4 #1 SMP Mon Jan 18 20:20:38 CET 2010 i686 Intel(R) Core(TM)2 Duo CPU P8600 @ 2.40GHz GenuineIntel GNU/Linux
>>
>>
> 
> That's a pre-0.12.1.2 qemu-kvm issue, upstream is not affected - or is
> at least not reporting it. It's already in my todo queue, just waiting
> to be dequeued.

I've looked into this a bit, and the bug message that pops up is in fact
new for your scenario (0.12.1.2->0.12.2, -vga std), it just happens to
trigger for me as well in a slightly different setup (CONFIG_FB_CIRRUS).

This is "mostly harmless" (the bug is gracefully handled), indicating
that qemu-kvm tries to enable/disable dirty logging for a VGA memory
area that was just unregistered. And that is because qemu-kvm tries to
keep support for old host kernels that had bugs and required workaround
approaches, but that code is bit-rotting a bit.

Avi, we should get rid of these messages, either by suppressing them in
qemu-kvm for now (stick your head into the sand...) or by finally
dropping all those dirty-logging diffs to upstream (in theory, there is
a third option: fixing the workaround code, but I don't think it's worth
the effort). What could be a road map for dropping? What distro kernels
are you aware of that may become unusable then?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2010-01-26 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-21  8:49 [Qemu-devel] regression between 0.12.1.2 and 0.12.2 Toralf Förster
2010-01-22 20:37 ` Jan Kiszka
2010-01-22 20:37   ` [Qemu-devel] " Jan Kiszka
2010-01-26 16:21   ` Jan Kiszka [this message]
2010-01-26 16:21     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5F1672.1040802@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.