From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: David Miller <davem@davemloft.net>
Cc: nicolas.dichtel@dev.6wind.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: IPsec rules are ineffective with ipv6
Date: Thu, 28 Jan 2010 15:24:18 +0000 [thread overview]
Message-ID: <4B61AC22.2050907@hp.com> (raw)
In-Reply-To: <20100128.055148.127214200.davem@davemloft.net>
David Miller wrote:
> From: Nicolas Dichtel <nicolas.dichtel@dev.6wind.com>
> Date: Wed, 27 Jan 2010 15:12:59 +0100
>
>> xfrm_lookup() is missing in sctp_v6_xmit(), add it.
>>
>> Signed-off-by: Junwei Zhang <junwei.zhang@6wind.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Doing this every transmit packet is overkill.
>
> Whatever calculates the route that ends up in skb_dst(skb)
> should be making this xfrm_lookup() call, not here.
>
Hmm.. Interesting. Looks like ip_route_output_key() will
do xfrm_lookup for you, but there is no ipv6 route lookup call
that will do the same thing.
I guess we'll need to add an xfrm_lookup call in sctp_v6_get_dst().
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: David Miller <davem@davemloft.net>
Cc: nicolas.dichtel@dev.6wind.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: IPsec rules are ineffective with ipv6
Date: Thu, 28 Jan 2010 10:24:18 -0500 [thread overview]
Message-ID: <4B61AC22.2050907@hp.com> (raw)
In-Reply-To: <20100128.055148.127214200.davem@davemloft.net>
David Miller wrote:
> From: Nicolas Dichtel <nicolas.dichtel@dev.6wind.com>
> Date: Wed, 27 Jan 2010 15:12:59 +0100
>
>> xfrm_lookup() is missing in sctp_v6_xmit(), add it.
>>
>> Signed-off-by: Junwei Zhang <junwei.zhang@6wind.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Doing this every transmit packet is overkill.
>
> Whatever calculates the route that ends up in skb_dst(skb)
> should be making this xfrm_lookup() call, not here.
>
Hmm.. Interesting. Looks like ip_route_output_key() will
do xfrm_lookup for you, but there is no ipv6 route lookup call
that will do the same thing.
I guess we'll need to add an xfrm_lookup call in sctp_v6_get_dst().
-vlad
next prev parent reply other threads:[~2010-01-28 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 14:12 [PATCH] sctp: IPsec rules are ineffective with ipv6 Nicolas Dichtel
2010-01-27 14:12 ` Nicolas Dichtel
2010-01-28 13:51 ` David Miller
2010-01-28 13:51 ` David Miller
2010-01-28 15:24 ` Vlad Yasevich [this message]
2010-01-28 15:24 ` Vlad Yasevich
2010-01-28 15:41 ` Nicolas Dichtel
2010-01-28 15:41 ` Nicolas Dichtel
2010-01-28 16:36 ` Vlad Yasevich
2010-01-28 16:36 ` Vlad Yasevich
2010-01-28 18:25 ` Nicolas Dichtel
2010-01-28 18:25 ` Nicolas Dichtel
2010-01-29 2:03 ` Wei Yongjun
2010-01-29 2:03 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B61AC22.2050907@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@dev.6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.