All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>, ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry
Date: Sat, 30 Jan 2010 10:13:45 -0600	[thread overview]
Message-ID: <4B645AB9.8050508@sandeen.net> (raw)
In-Reply-To: <20100130105236.GA18286@infradead.org>

Christoph Hellwig wrote:
>> +# real QA test starts here
>> +_supported_fs xfs ext4
> 
> I'd make this generic and just do the notrun in scratch_mkfs_geom for
> non-supported filesystems.

fair enough

>> +scratch_mkfs_geom()
>> +{
> 
> And I'd throw this one into common.rc.

ok

>> +=== Testing size 1073745920 falloc on 128k stripe ===
>> +SCRATCH_MNT/file-1073745920-falloc: well-aligned
>> diff --git a/common.rc b/common.rc
>> index 6424871..97513cc 100644
>> --- a/common.rc
>> +++ b/common.rc
>> @@ -292,7 +292,7 @@ _scratch_mkfs()
>>          $MKFS_UDF_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>>  	;;
>>      *)
>> -	/sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>> +	/sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> 
> Hmm, doesn't this change break other testcase?  Anyway needs some
> rationale in the changelog.

didn't break anything for me; I wanted to be able to see the mkfs
results w/ geometry, is all.  Will re-double-check but it was fine AFAIK.

>> index 0000000..fa005b2
>> --- /dev/null
>> +++ b/src/fibmap.c
> 
> This is a bit misnamed as it's not a generic fibmap tool but rather
> a specific tool comparing the bmap to the sunit alignment.
> 

good point .. how about making it more generic, something like:

fibmap -o <file offset> -l <length> -s <stripe alignment> <filename>

hmm though I hate to reqwrite filefrag ... :)

I suppose something like this could go into xfs_io as well, but that
makes this test unavailable to the masses until another release, at least.

-Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: ext4 development <linux-ext4@vger.kernel.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry
Date: Sat, 30 Jan 2010 10:13:45 -0600	[thread overview]
Message-ID: <4B645AB9.8050508@sandeen.net> (raw)
In-Reply-To: <20100130105236.GA18286@infradead.org>

Christoph Hellwig wrote:
>> +# real QA test starts here
>> +_supported_fs xfs ext4
> 
> I'd make this generic and just do the notrun in scratch_mkfs_geom for
> non-supported filesystems.

fair enough

>> +scratch_mkfs_geom()
>> +{
> 
> And I'd throw this one into common.rc.

ok

>> +=== Testing size 1073745920 falloc on 128k stripe ===
>> +SCRATCH_MNT/file-1073745920-falloc: well-aligned
>> diff --git a/common.rc b/common.rc
>> index 6424871..97513cc 100644
>> --- a/common.rc
>> +++ b/common.rc
>> @@ -292,7 +292,7 @@ _scratch_mkfs()
>>          $MKFS_UDF_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>>  	;;
>>      *)
>> -	/sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
>> +	/sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
> 
> Hmm, doesn't this change break other testcase?  Anyway needs some
> rationale in the changelog.

didn't break anything for me; I wanted to be able to see the mkfs
results w/ geometry, is all.  Will re-double-check but it was fine AFAIK.

>> index 0000000..fa005b2
>> --- /dev/null
>> +++ b/src/fibmap.c
> 
> This is a bit misnamed as it's not a generic fibmap tool but rather
> a specific tool comparing the bmap to the sunit alignment.
> 

good point .. how about making it more generic, something like:

fibmap -o <file offset> -l <length> -s <stripe alignment> <filename>

hmm though I hate to reqwrite filefrag ... :)

I suppose something like this could go into xfs_io as well, but that
makes this test unavailable to the masses until another release, at least.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-01-30 16:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 22:52 [PATCH] xfstests: 223 - test file alignment on stripe geometry Eric Sandeen
2010-01-30 10:52 ` Christoph Hellwig
2010-01-30 10:52   ` Christoph Hellwig
2010-01-30 16:13   ` Eric Sandeen [this message]
2010-01-30 16:13     ` Eric Sandeen
2010-01-30 19:09     ` Christoph Hellwig
2010-01-30 19:09       ` Christoph Hellwig
2010-02-02 23:28   ` [PATCH V2] " Eric Sandeen
2010-02-02 23:28     ` Eric Sandeen
2010-02-03  1:48     ` [PATCH V3] " Eric Sandeen
2010-02-03 10:58       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B645AB9.8050508@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.