All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Stephan Beyer <s-beyer@gmx.net>,
	Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [RFC/PATCH 5/6] revert: add --ff option to allow fast forward when cherry-picking
Date: Mon, 01 Feb 2010 12:10:04 +0100	[thread overview]
Message-ID: <4B66B68C.7050505@gnu.org> (raw)
In-Reply-To: <20100201075542.3929.35967.chriscool@tuxfamily.org>

> +		OPT_BOOLEAN(0, "ff",&ff_ok, "allow fast forward"),

Why should this not be the default?  Instead, you'd add --no-ff.  This 
would simplify 6/6 further, like

   eval sha1=\$$#
   ...
   output git cherry-pick "$@"

Paolo

  reply	other threads:[~2010-02-01 11:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01  7:55 [RFC/PATCH 0/6] add --ff option to cherry-pick Christian Couder
2010-02-01  7:55 ` [RFC/PATCH 1/6] revert: libify cherry-pick and revert functionnality Christian Couder
2010-02-01 10:26   ` Johannes Schindelin
2010-02-03 16:40   ` Stephen Boyd
2010-02-01  7:55 ` [RFC/PATCH 2/6] reset: refactor updating heads into a static function Christian Couder
2010-02-01  7:55 ` [RFC/PATCH 3/6] reset: refactor reseting in its own function Christian Couder
2010-02-01  7:55 ` [RFC/PATCH 4/6] reset: make reset function non static and declare it in "reset.h" Christian Couder
2010-02-01  7:55 ` [RFC/PATCH 5/6] revert: add --ff option to allow fast forward when cherry-picking Christian Couder
2010-02-01 11:10   ` Paolo Bonzini [this message]
2010-02-01 12:43     ` Christian Couder
2010-02-01 14:29       ` Paolo Bonzini
2010-02-02  5:13         ` Christian Couder
2010-02-02  7:56           ` Paolo Bonzini
2010-02-01  7:55 ` [RFC/PATCH 6/6] rebase -i: use new --ff cherry-pick option Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B66B68C.7050505@gnu.org \
    --to=bonzini@gnu.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=s-beyer@gmx.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.