From: Alex Zeffertt <alex.zeffertt@eu.citrix.com>
To: dm-devel@redhat.com
Subject: [PATCH] multipathd pthread locking fix
Date: Wed, 3 Feb 2010 11:39:25 +0000 [thread overview]
Message-ID: <4B69606D.2090206@eu.citrix.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 97 bytes --]
The following patch is needed to stop multipathd segfaulting on uClibc.
Regards,
Alex Zeffertt
[-- Attachment #2: dm-multipath-fix-pthread-bug.patch --]
[-- Type: text/x-diff, Size: 613 bytes --]
Fix pthread bug in multipath-tools.
You should lock the mutex before doing a pthread_cond_wait otherwise
undefined results occur. In fact we get away with this with glibc,
but with uclibc it causes a segfault.
Signed-off-by: Alex Zeffertt <alex.zeffertt@eu.citrix.com>
--- ./multipathd/main.c.orig 2010-02-03 05:42:14.000000000 -0500
+++ ./multipathd/main.c 2010-02-03 05:43:13.000000000 -0500
@@ -1668,6 +1668,7 @@
/*pthread_create(&uevent_thr, &attr, ueventloop, vecs);*/
pthread_create(&uxlsnr_thr, &attr, uxlsnrloop, vecs);
+ lock(&exit_mutex);
pthread_cond_wait(&exit_cond, &exit_mutex);
/*
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2010-02-03 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 11:39 Alex Zeffertt [this message]
2010-02-03 12:31 ` [PATCH] multipathd pthread locking fix Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B69606D.2090206@eu.citrix.com \
--to=alex.zeffertt@eu.citrix.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.