[PATCH] multipathd pthread locking fix

* [PATCH] multipathd pthread locking fix
@ 2010-02-03 11:39 Alex Zeffertt
  2010-02-03 12:31 ` Christophe Varoqui
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Zeffertt @ 2010-02-03 11:39 UTC (permalink / raw)
  To: dm-devel

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

The following patch is needed to stop multipathd segfaulting on uClibc.

Regards,

Alex Zeffertt

[-- Attachment #2: dm-multipath-fix-pthread-bug.patch --]
[-- Type: text/x-diff, Size: 613 bytes --]

Fix pthread bug in multipath-tools.

You should lock the mutex before doing a pthread_cond_wait otherwise
undefined results occur.  In fact we get away with this with glibc,
but with uclibc it causes a segfault.


Signed-off-by: Alex Zeffertt <alex.zeffertt@eu.citrix.com>

--- ./multipathd/main.c.orig	2010-02-03 05:42:14.000000000 -0500
+++ ./multipathd/main.c	2010-02-03 05:43:13.000000000 -0500
@@ -1668,6 +1668,7 @@
 	/*pthread_create(&uevent_thr, &attr, ueventloop, vecs);*/
 	pthread_create(&uxlsnr_thr, &attr, uxlsnrloop, vecs);
 
+	lock(&exit_mutex);
 	pthread_cond_wait(&exit_cond, &exit_mutex);
 
 	/*

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread