From: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
To: Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 08/9] ib/iser: move to use libiscsi passthrough mode
Date: Wed, 03 Feb 2010 15:32:10 -0600 [thread overview]
Message-ID: <4B69EB5A.4050301@cs.wisc.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.1002031740540.11944-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
On 02/03/2010 09:41 AM, Or Gerlitz wrote:
> @@ -526,17 +523,8 @@ void iser_snd_completion(struct iser_tx_
> kmem_cache_free(ig.desc_cache, tx_desc);
> }
>
> - if (atomic_read(&iser_conn->ib_conn->post_send_buf_count) ==
> - ISER_QP_MAX_REQ_DTOS)
> - resume_tx = 1;
> -
> atomic_dec(&ib_conn->post_send_buf_count);
>
> - if (resume_tx) {
> - iser_dbg("%ld resuming tx\n",jiffies);
> - iscsi_conn_queue_work(conn);
> - }
What prevents the problem this code was handling from coming up now? Are
you now preallocating enough resources, or are you returning
-ENOMEM/-ENOBUFS from the init_task/xmit_task callouts so the scsi layer
is now requeueing the IO?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-03 21:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 15:30 [PATCH 0/8] ib/iser: major face lift of the data path code Or Gerlitz
[not found] ` <Pine.LNX.4.64.1002031721280.11944-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
2010-02-03 15:31 ` [PATCH 01/9] ib/iser: revert commit bba7ebb "avoid recv buffer exhaustion" Or Gerlitz
2010-02-03 15:33 ` [PATCH 02/9] ib/iser: new recv buffer posting logic Or Gerlitz
2010-02-03 15:35 ` [PATCH 03/9] ib/iser: remove atomic counter for posted recv buffers Or Gerlitz
2010-02-03 15:36 ` [PATCH 04/9] ib/iser: use different CQ for send completions Or Gerlitz
2010-02-03 15:37 ` [PATCH 05/9] ib/iser: simplify send flow/descriptors Or Gerlitz
[not found] ` <Pine.LNX.4.64.1002031737090.11944-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
2010-02-04 11:23 ` Or Gerlitz
2010-02-03 15:39 ` [PATCH 06/9] ib/iser: use atomic allocations Or Gerlitz
2010-02-03 15:40 ` [PATCH 07/9] ib/iser: remove unnecessary connection checks Or Gerlitz
2010-02-03 15:41 ` [PATCH 08/9] ib/iser: move to use libiscsi passthrough mode Or Gerlitz
[not found] ` <Pine.LNX.4.64.1002031740540.11944-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
2010-02-03 21:32 ` Mike Christie [this message]
[not found] ` <4B69EB5A.4050301-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2010-02-04 11:21 ` Or Gerlitz
[not found] ` <4B6AADD4.2050607-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-02-04 17:27 ` Mike Christie
2010-02-03 15:42 ` [PATCH 08/10] ib/iser: remove redundant locking from command response flow Or Gerlitz
2010-02-03 15:44 ` [PATCH 09/9] remove redundant locking from iser scsi " Or Gerlitz
2010-02-03 16:10 ` [PATCH 0/8] ib/iser: major face lift of the data path code Bart Van Assche
2010-02-03 16:11 ` Bart Van Assche
[not found] ` <e2e108261002030811r5c740d6fr4cc055702a88aa50-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-04 14:21 ` Or Gerlitz
[not found] ` <4B6AD7D5.7030204-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-02-05 12:18 ` Vladislav Bolkhovitin
[not found] ` <4B6C0C93.2090107-d+Crzxg7Rs0@public.gmane.org>
2010-02-07 14:51 ` Or Gerlitz
2010-02-05 12:29 ` Vladislav Bolkhovitin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B69EB5A.4050301@cs.wisc.edu \
--to=michaelc-hcno3ddehluvc3sceru5cw@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.