Re: [PATCH 08/9] ib/iser: move to use libiscsi passthrough mode

[Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>]

On 02/04/2010 05:21 AM, Or Gerlitz wrote:

>
> [PATCH V2 08/9] ib/iser: move to use libiscsi passthrough mode
>
> The libiscsi passthrough mode invokes the transport xmit calls directly
> without first going through an internal queue as done in the other mode
> which uses a queue and a xmitworker thread. Now when the "cant_sleep"
> prerequisite of iscsi_host_alloc is met, move to use it. Handling xmit
> errors is now done by  the passthrough flow of libiscsi. Since the
> queue/worker aren't used in this mode, the code that schedules the
> xmitworker is removed.
>
> Signed-off-by: Or Gerlitz<ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
>
> ---
>
> changes from V1:
>
> - remove calls to iscsi_conn_failure which are under now both buggy and not needed, instead
>    return errors to libiscsi (e.g iscsi_queuecommand, __iscsi_conn_send_pdu)
> - enhance/fix the two debug prints and the change log
>

Looks ok.

Reviewed-by: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html