From: Tejun Heo <tj@kernel.org>
To: Andy Isaacson <adi@hexapodia.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
Subject: Re: [2.6.33-rc6-git regression] idr fix breaks Xorg
Date: Thu, 04 Feb 2010 12:11:41 +0900 [thread overview]
Message-ID: <4B6A3AED.1000102@kernel.org> (raw)
In-Reply-To: <20100204012837.GC538@hexapodia.org>
On 02/04/2010 10:28 AM, Andy Isaacson wrote:
> On my Dell Latitude e4300 commit 859ddf0974 ("idr: fix a critical
> misallocation bug") causes Xorg to segfault with the following
> backtrace:
Does the following patch make any difference?
diff --git a/lib/idr.c b/lib/idr.c
index ba7d37c..a96c604 100644
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -140,7 +140,8 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
id = *starting_id;
restart:
p = idp->top;
- l = p->layer;
+ l = idp->layers;
+ pa[l--] = NULL;
while (1) {
/*
* We run around this while until we reach the leaf node...
--
tejun
next prev parent reply other threads:[~2010-02-04 3:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 1:28 [2.6.33-rc6-git regression] idr fix breaks Xorg Andy Isaacson
2010-02-04 3:11 ` Tejun Heo [this message]
2010-02-04 7:08 ` Andy Isaacson
2010-02-04 7:56 ` Andy Isaacson
2010-02-04 8:16 ` Tejun Heo
2010-02-04 8:40 ` Dave Airlie
2010-02-04 8:40 ` Dave Airlie
2010-02-04 8:45 ` Tejun Heo
2010-02-04 9:39 ` Chris Wilson
2010-02-11 8:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6A3AED.1000102@kernel.org \
--to=tj@kernel.org \
--cc=adi@hexapodia.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.