From: Tejun Heo <tj@kernel.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andy Isaacson <adi@hexapodia.org>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [2.6.33-rc6-git regression] idr fix breaks Xorg
Date: Thu, 11 Feb 2010 17:50:38 +0900 [thread overview]
Message-ID: <4B73C4DE.6000507@kernel.org> (raw)
In-Reply-To: <89k83a$756q97@azsmga001.ch.intel.com>
Hello,
Can you please test the following patch on top of the current
mainline? Thanks.
diff --git a/lib/idr.c b/lib/idr.c
index 1cac726..0dc7822 100644
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -156,10 +156,12 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
id = (id | ((1 << (IDR_BITS * l)) - 1)) + 1;
/* if already at the top layer, we need to grow */
- if (!(p = pa[l])) {
+ if (id >= 1 << (idp->layers * IDR_BITS)) {
*starting_id = id;
return IDR_NEED_TO_GROW;
}
+ p = pa[l];
+ BUG_ON(!p);
/* If we need to go up one layer, continue the
* loop; otherwise, restart from the top.
--
tejun
prev parent reply other threads:[~2010-02-11 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 1:28 [2.6.33-rc6-git regression] idr fix breaks Xorg Andy Isaacson
2010-02-04 3:11 ` Tejun Heo
2010-02-04 7:08 ` Andy Isaacson
2010-02-04 7:56 ` Andy Isaacson
2010-02-04 8:16 ` Tejun Heo
2010-02-04 8:40 ` Dave Airlie
2010-02-04 8:40 ` Dave Airlie
2010-02-04 8:45 ` Tejun Heo
2010-02-04 9:39 ` Chris Wilson
2010-02-11 8:50 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B73C4DE.6000507@kernel.org \
--to=tj@kernel.org \
--cc=adi@hexapodia.org \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.