From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 1/1] CLD: regression in unified cld_timer
Date: Tue, 09 Feb 2010 17:51:04 -0500 [thread overview]
Message-ID: <4B71E6D8.7000402@garzik.org> (raw)
In-Reply-To: <20100209100210.2ba1dda5@redhat.com>
On 02/09/2010 12:02 PM, Pete Zaitcev wrote:
> The common timer implementation had a bug whereas it overwrote the list
> of timers when a timer callback added its own timer -- which just about
> every one of them does. The most visible result was that sessions stopped
> expiring correctly and left dangling file locks. Also, every new session
> failed after 2 minutes 35 seconds.
>
> The fix is not to keep a local copy of the list head across invocations
> of the callback.
>
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
> lib/libtimer.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Jeff& Colin: sorry to waste your time with inferences that the change
> to XDR was somehow involved. I guess I did not update the CLD on the
> server since before the common timer.
applied
prev parent reply other threads:[~2010-02-09 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 17:02 [Patch 1/1] CLD: regression in unified cld_timer Pete Zaitcev
2010-02-09 22:51 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B71E6D8.7000402@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.