Re: [PATCH] ASoC: TWL4030: Add supply for audio serial interface control

[Joonyoung Shim <jy0922.shim@samsung.com>]

On 2/9/2010 10:24 PM, Peter Ujfalusi wrote:
> The serial interface (TDM/I2S) for the audio block have been
> constantly enabled.
> Introduce a new DAPM_SUPPLY for handling the AIF_EN bit, so
> the interface is only enabled, when there is a need for it.
> For example when only the analog loopback is enabled, there
> is no need to keep the serial interface active.
> 
> I have added the persons who contributed to the Voice path
> of twl4030 codec driver, so they might have the ability
> to test this patch, and send an update for the Voice path,
> if it is necessary
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> 
> This patch has been tested in OPTION 1 mode, where the Voice
> path is not in use.
> I have looked for dependencies in the Voice path regarding to 
> the Audio interface enable bit, but I have not found any.
> If someone could test, if the Voice path also needs the AIF_EN
> bit set, than please send a patch, which adds this new supply
> to the DAPM rule for the Voice path.
> 

Unfortunately, i cannot test the twl4030 codec anymore, but i think
there is no dependency in the Voice path by this patch. The AIF_EN bit
is only for the audio interface(DIN, DOUT, SYNC, CLK).