Re: [PATCH] a new filessytem module for nilfs2

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

Jiro SEKIBA wrote:
> Hi,
>
> This is a patch to support nilfs2 filesystem.
> I would like you to review the patch.
>
> I've checked with revno 2153 and kvm(qemu) environment.
>
> Also the patch has already an ability to boot the kernel from
> the nilfs partition, I have a following ToDo list to improve the module.
>
> 1. revision check for future disk layout changes
> 2. CRC check for superblock to ensure the partition is a nilfs2 partition
> 3. CRC check latest log block to ensure valid log 
> 4. search the latest log in case unclean unmount happened
>
> nilfs2 stands for New Implementation of Log Filesystem version2.
> nilfs2 has been merged into linux main line kernel since 2.6.30.
>
> Please give me any comments or advice.
>
> thank you very much in advance
>   

+pkglib_MODULES += fshelp.mod fat.mod ufs1.mod ufs2.mod ext2.mod
nilfs2.mod \
+       ntfs.mod ntfscomp.mod minix.mod hfs.mod jfs.mod iso9660.mod
xfs.mod \

For new modules we prefer to add pkglib_MODULES+= directly before the
module itself
+/* ext2.c - Second Extended filesystem */
+/*
Leftover
+#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))
This can go into misc.h
iterate_dir:
+  /* Search the file.  */
+  while (fpos < grub_le_to_cpu64 (diro->inode.i_size))
+    {
Another leftover
I'm no nilfs2 expert but assuming that it works it's a good patch. Have
you tested it on big-endian system? If no nd you have no access to such
send me testing instructions, I have a powerpc machine (or one can use
qemu).
Nice job
> ------------------------------------------------------------------------
>
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]