Re: [PATCH 4/4] netfilter: xtables: generate initial table on-demand

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> +void *arpt_alloc_initial_table(const struct xt_table *info)
> +{
> +	return xt_repldata_mk(arpt, ARPT);

I vaguely recall asking for a nicer (more pronouncable) name.
xt_alloc_initial_table() perhaps? xt_init_table()?

>  static int __net_init nf_nat_rule_net_init(struct net *net)
>  {
> -	net->ipv4.nat_table = ipt_register_table(net, &nat_table,
> -						 &nat_initial_table.repl);
> +	struct ipt_replace *repl = ipt_alloc_initial_table(&nat_table);
> +

Minor request: I'd prefer to have the allocation next to the NULL check
instead of in the variable definition.

> +	if (repl == NULL)
> +		return -ENOMEM;
> +	net->ipv4.nat_table = ipt_register_table(net, &nat_table, repl);
> +	kfree(repl);
>  	if (IS_ERR(net->ipv4.nat_table))
>  		return PTR_ERR(net->ipv4.nat_table);
>  	return 0;