From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/4] netfilter: xtables: use xt_table for hook instantiation
Date: Wed, 10 Feb 2010 20:46:28 +0100 [thread overview]
Message-ID: <4B730D14.5080407@trash.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1002102042190.28163@obet.zrqbmnf.qr>
Jan Engelhardt wrote:
> On Wednesday 2010-02-10 20:26, Jozsef Kadlecsik wrote:
>>> This might actually be a bug. IPv4 uses:
>>>
>>> NF_IP_PRI_FIRST = INT_MIN,
>>> NF_IP_PRI_CONNTRACK_DEFRAG = -400,
>>> NF_IP_PRI_RAW = -300,
>>> NF_IP_PRI_SELINUX_FIRST = -225,
>>> NF_IP_PRI_CONNTRACK = -200,
>>>
>>> while IPv6 uses:
>>>
>>> NF_IP6_PRI_FIRST = INT_MIN,
>>> NF_IP6_PRI_CONNTRACK_DEFRAG = -400,
>>> NF_IP6_PRI_SELINUX_FIRST = -225,
>>> NF_IP6_PRI_CONNTRACK = -200,
>>>
>>> So we actually defragment packets in IPv4 even though they're
>>> untracked. Perhaps Jozsef knows more details why we use
>>> different priorities here.
>> We have to defragment otherwise we could not track and untrack connections
>> at the same time. Fragments don't carry protocol/port so we cannot tell
>> which fragment belongs to a not tracked and which one belongs to a tracked
>> connection.
>
> How so? If I untrack something in the raw table, I would have
> assumed it skips all conntracking - including defrag.
>
> Even before defrag, what's wrong with skb->nfct = &the_untracked_conn?
You can't construct your ruleset to properly deal with fragments.
next prev parent reply other threads:[~2010-02-10 19:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 14:59 static data reduction, 2010-02-10 Jan Engelhardt
2010-02-10 14:59 ` [PATCH 1/4] netfilter: xtables: compact table hook functions (1/2) Jan Engelhardt
2010-02-10 15:22 ` Patrick McHardy
2010-02-10 15:32 ` Jan Engelhardt
2010-02-10 14:59 ` [PATCH 2/4] netfilter: xtables: compact table hook functions (2/2) Jan Engelhardt
2010-02-10 15:24 ` Patrick McHardy
2010-02-10 14:59 ` [PATCH 3/4] netfilter: xtables: use xt_table for hook instantiation Jan Engelhardt
2010-02-10 15:27 ` Patrick McHardy
2010-02-10 16:05 ` Jan Engelhardt
2010-02-10 16:10 ` Patrick McHardy
2010-02-10 19:26 ` Jozsef Kadlecsik
2010-02-10 19:43 ` Jan Engelhardt
2010-02-10 19:46 ` Patrick McHardy [this message]
2010-02-10 20:09 ` Jan Engelhardt
2010-02-10 21:32 ` Jozsef Kadlecsik
2010-02-10 22:07 ` Jan Engelhardt
2010-02-10 22:10 ` Jan Engelhardt
2010-02-10 15:33 ` Patrick McHardy
2010-02-10 16:07 ` Jan Engelhardt
2010-02-10 14:59 ` [PATCH 4/4] netfilter: xtables: generate initial table on-demand Jan Engelhardt
2010-02-10 15:32 ` Patrick McHardy
2010-02-10 16:21 ` Jan Engelhardt
2010-02-10 16:25 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2010-02-10 16:51 static data reduction Jan Engelhardt
2010-02-10 16:51 ` [PATCH 3/4] netfilter: xtables: use xt_table for hook instantiation Jan Engelhardt
2010-02-07 11:49 Stomping Static Data pull, 2010-02-07 Jan Engelhardt
2010-02-07 11:49 ` [PATCH 3/4] netfilter: xtables: use xt_table for hook instantiation Jan Engelhardt
2009-10-10 9:22 stomping static data pull Jan Engelhardt
2009-10-10 9:22 ` [PATCH 3/4] netfilter: xtables: use xt_table for hook instantiation Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B730D14.5080407@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.