* [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command
@ 2010-02-12 20:14 Adam Litke
2010-02-12 20:50 ` [Qemu-devel] " Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Adam Litke @ 2010-02-12 20:14 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Hi Anthony. I wonder if there was a problem when importing my async
command handler patchset. Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing but is added by the patch below.
diff --git a/monitor.c b/monitor.c
index ae125b8..f94794d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
return -1;
}
+ cb(opaque, NULL);
return 0;
}
--
Thanks,
Adam
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] Fix hanging user monitor when using balloon command
2010-02-12 20:14 [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command Adam Litke
@ 2010-02-12 20:50 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-02-12 20:50 UTC (permalink / raw)
To: Adam Litke; +Cc: qemu-devel
On 02/12/2010 02:14 PM, Adam Litke wrote:
> Hi Anthony. I wonder if there was a problem when importing my async
> command handler patchset. Since the 'balloon' command completes
> immediately, it must call the completion callback before returning.
> That call was missing but is added by the patch below.
>
Needs a Signed-off-by. I don't recall any fuzz with your patch but that
was a few hundred patches ago :-)
Regards,
Anthony Liguori
> diff --git a/monitor.c b/monitor.c
> index ae125b8..f94794d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
> return -1;
> }
>
> + cb(opaque, NULL);
> return 0;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-12 20:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12 20:14 [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command Adam Litke
2010-02-12 20:50 ` [Qemu-devel] " Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.