[PATCH] eglibc:

[PATCH] eglibc:

[Thomas Zimmermann]

* ldd has shebang #!/bin/bash: so add bash RDEPNDS
* add libpthread_nonshared.a to eglibc-dev, needed for building
  multithreaded apps on the device
---
 recipes/eglibc/eglibc-package.bbclass |    3 ++-
 recipes/eglibc/eglibc.inc             |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/recipes/eglibc/eglibc-package.bbclass b/recipes/eglibc/eglibc-package.bbclass
index fcaba47..7187363 100644
--- a/recipes/eglibc/eglibc-package.bbclass
+++ b/recipes/eglibc/eglibc-package.bbclass
@@ -45,10 +45,11 @@ libc_baselibs = "${base_libdir}/libcrypt*.so.* ${base_libdir}/libcrypt-*.so ${ba
 
 FILES_${PN} = "${libc_baselibs} ${libexecdir}/* ${@base_conditional('USE_LDCONFIG', '1', '${base_sbindir}/ldconfig', '', d)}"
 FILES_ldd = "${bindir}/ldd"
+RDEPENDS_ldd = "bash"
 FILES_libsegfault = "${base_libdir}/libSegFault*"
 FILES_eglibc-extra-nss = "${base_libdir}/libnss*"
 FILES_sln = "/sbin/sln"
-FILES_eglibc-dev_append = " ${libdir}/*.o ${bindir}/rpcgen ${libdir}/libc_nonshared.a"
+FILES_eglibc-dev_append = " ${libdir}/*.o ${bindir}/rpcgen ${libdir}/libc_nonshared.a ${libdir}/libpthread_nonshared.a"
 FILES_nscd = "${sbindir}/nscd*"
 FILES_eglibc-utils = "${bindir}/* ${sbindir}/*"
 FILES_eglibc-gconv = "${libdir}/gconv/*"
diff --git a/recipes/eglibc/eglibc.inc b/recipes/eglibc/eglibc.inc
index 356b838..5c06ae6 100644
--- a/recipes/eglibc/eglibc.inc
+++ b/recipes/eglibc/eglibc.inc
@@ -3,7 +3,7 @@ HOMEPAGE = "http://www.eglibc.org/home"
 SECTION = "libs"
 PRIORITY = "required"
 LICENSE = "LGPL"
-INC_PR = "r8"
+INC_PR = "r9"
 # nptl needs unwind support in gcc, which can't be built without glibc.
 DEPENDS = "virtual/${TARGET_PREFIX}gcc-intermediate linux-libc-headers"
 #this leads to circular deps, so lets not add it yet
-- 
1.6.6.1

Re: [PATCH] eglibc:

[Petr Štetiar]

Hi, you probably would like to modify the subject :)

-- ynezz

Re: [PATCH] eglibc: small packaging fixes

[Thomas Zimmermann]

Am Freitag 12 Februar 2010 14:08:43 schrieb Petr Štetiar:
> Hi, you probably would like to modify the subject :)
> 
> -- ynezz
I had no idea for a good summery.
But this patch needs to be ACK'ed so i think we can add a better subject when 
commiting.

Thomas

Re: [PATCH] eglibc:

[Khem Raj]

On Fri, Feb 12, 2010 at 5:05 AM, Thomas Zimmermann <ml@vdm-design.de> wrote:
> * ldd has shebang #!/bin/bash: so add bash RDEPNDS
> * add libpthread_nonshared.a to eglibc-dev, needed for building
>  multithreaded apps on the device

patch is ok.

> ---
>  recipes/eglibc/eglibc-package.bbclass |    3 ++-
>  recipes/eglibc/eglibc.inc             |    2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/eglibc/eglibc-package.bbclass b/recipes/eglibc/eglibc-package.bbclass
> index fcaba47..7187363 100644
> --- a/recipes/eglibc/eglibc-package.bbclass
> +++ b/recipes/eglibc/eglibc-package.bbclass
> @@ -45,10 +45,11 @@ libc_baselibs = "${base_libdir}/libcrypt*.so.* ${base_libdir}/libcrypt-*.so ${ba
>
>  FILES_${PN} = "${libc_baselibs} ${libexecdir}/* ${@base_conditional('USE_LDCONFIG', '1', '${base_sbindir}/ldconfig', '', d)}"
>  FILES_ldd = "${bindir}/ldd"
> +RDEPENDS_ldd = "bash"
>  FILES_libsegfault = "${base_libdir}/libSegFault*"
>  FILES_eglibc-extra-nss = "${base_libdir}/libnss*"
>  FILES_sln = "/sbin/sln"
> -FILES_eglibc-dev_append = " ${libdir}/*.o ${bindir}/rpcgen ${libdir}/libc_nonshared.a"
> +FILES_eglibc-dev_append = " ${libdir}/*.o ${bindir}/rpcgen ${libdir}/libc_nonshared.a ${libdir}/libpthread_nonshared.a"
>  FILES_nscd = "${sbindir}/nscd*"
>  FILES_eglibc-utils = "${bindir}/* ${sbindir}/*"
>  FILES_eglibc-gconv = "${libdir}/gconv/*"
> diff --git a/recipes/eglibc/eglibc.inc b/recipes/eglibc/eglibc.inc
> index 356b838..5c06ae6 100644
> --- a/recipes/eglibc/eglibc.inc
> +++ b/recipes/eglibc/eglibc.inc
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://www.eglibc.org/home"
>  SECTION = "libs"
>  PRIORITY = "required"
>  LICENSE = "LGPL"
> -INC_PR = "r8"
> +INC_PR = "r9"
>  # nptl needs unwind support in gcc, which can't be built without glibc.
>  DEPENDS = "virtual/${TARGET_PREFIX}gcc-intermediate linux-libc-headers"
>  #this leads to circular deps, so lets not add it yet
> --
> 1.6.6.1
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] eglibc:

[Florian Boor]

Hi,

Thomas Zimmermann schrieb:
> * ldd has shebang #!/bin/bash: so add bash RDEPNDS

last time I checked it worked with the Busybox built-in shell as well. I wonder
if it would be a good idea to verify this and patch ldd for our purposes.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

Re: [PATCH] eglibc:

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 14-02-10 23:33, Florian Boor wrote:
> Hi,
> 
> Thomas Zimmermann schrieb:
>> * ldd has shebang #!/bin/bash: so add bash RDEPNDS
> 
> last time I checked it worked with the Busybox built-in shell as well. I wonder
> if it would be a good idea to verify this and patch ldd for our purposes.

like this:
http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/glibc/glibc-2.4/ldd-unbash.patch
?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLeHtGMkyGM64RGpERAh6qAKCWso8PlsudZmYBWHY5xR9KyWxYWQCfdHTf
5P8Zv9JKV8DLJzC29+nqh3E=
=uFhP
-----END PGP SIGNATURE-----

Re: [PATCH] eglibc:

[Khem Raj]

On Sun, Feb 14, 2010 at 2:37 PM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 14-02-10 23:33, Florian Boor wrote:
>> Hi,
>>
>> Thomas Zimmermann schrieb:
>>> * ldd has shebang #!/bin/bash: so add bash RDEPNDS
>>
>> last time I checked it worked with the Busybox built-in shell as well. I wonder
>> if it would be a good idea to verify this and patch ldd for our purposes.
>
> like this:
> http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/glibc/glibc-2.4/ldd-unbash.patch
> ?

or patch posted in http://sourceware.org/bugzilla/show_bug.cgi?id=832
it lets it work as it is if shell is bash.

Thx

-Khem

Re: [PATCH] eglibc:

[Thomas Zimmermann]

Am Freitag 19 Februar 2010 01:28:57 schrieb Khem Raj:
> On Sun, Feb 14, 2010 at 2:37 PM, Koen Kooi <k.kooi@student.utwente.nl> 
wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 14-02-10 23:33, Florian Boor wrote:
> >> Hi,
> >>
> >> Thomas Zimmermann schrieb:
> >>> * ldd has shebang #!/bin/bash: so add bash RDEPNDS
> >>
> >> last time I checked it worked with the Busybox built-in shell as well. I
> >> wonder if it would be a good idea to verify this and patch ldd for our
> >> purposes.
> >
> > like this:
> > http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/glibc/gli
> >bc-2.4/ldd-unbash.patch ?
> 
> or patch posted in http://sourceware.org/bugzilla/show_bug.cgi?id=832
> it lets it work as it is if shell is bash.
> 
> Thx
> 
> -Khem
I tried ldd today with busyboy and it was enough to replace just the shebang:

--- /usr/bin/ldd        Fri Feb 19 08:27:44 2010
+++ /usr/bin/ldd        Fri Feb 19 08:27:51 2010
@@ -1,4 +1,4 @@
-#! /bin/bash
+#! /bin/sh
 # Copyright (C) 1996-2008, 2009 Free Software Foundation, Inc.
 # This file is part of the GNU C Library.

I think this is because we have in eglibc:

if x=`set -o` && test "$x" != "${x#*pipefail}" && set -o pipefail ; then

and the second term fails, so set -o pipefail is never executed.

I will resend this patch.

Thomas

[PATCH] eglibc: unbash ldd and add libpthread_nonshared.a to -dev

[Thomas Zimmermann]

* replace shebang of ldd by /bin/sh, so ldd doesn't depend on bash
  anymore. Tested with busybox sh.
* added to do_configure_prepend because do_patch is only a python function
* add libpthread_nonshared.a to eglibc-dev. Now it's possible to
  compile multithreaded applications on the device.
---
 recipes/eglibc/eglibc-package.bbclass |    6 +++++-
 recipes/eglibc/eglibc.inc             |    2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/recipes/eglibc/eglibc-package.bbclass b/recipes/eglibc/eglibc-package.bbclass
index fcaba47..3c33f93 100644
--- a/recipes/eglibc/eglibc-package.bbclass
+++ b/recipes/eglibc/eglibc-package.bbclass
@@ -48,7 +48,7 @@ FILES_ldd = "${bindir}/ldd"
 FILES_libsegfault = "${base_libdir}/libSegFault*"
 FILES_eglibc-extra-nss = "${base_libdir}/libnss*"
 FILES_sln = "/sbin/sln"
-FILES_eglibc-dev_append = " ${libdir}/*.o ${bindir}/rpcgen ${libdir}/libc_nonshared.a"
+FILES_eglibc-dev_append = " ${libdir}/*.o ${bindir}/rpcgen ${libdir}/libc_nonshared.a ${libdir}/libpthread_nonshared.a"
 FILES_nscd = "${sbindir}/nscd*"
 FILES_eglibc-utils = "${bindir}/* ${sbindir}/*"
 FILES_eglibc-gconv = "${libdir}/gconv/*"
@@ -76,6 +76,10 @@ EXTRA_OECONF += "${@get_eglibc_fpu_setting(bb, d)}"
 
 OVERRIDES_append = ":${TARGET_ARCH}-${TARGET_OS}"
 
+do_configure_prepend() {
+        sed -e "s#@BASH@#/bin/sh#" -i ${S}/elf/ldd.bash.in
+}
+
 do_install() {
 	oe_runmake install_root=${D} install
 	for r in ${rpcsvc}; do
diff --git a/recipes/eglibc/eglibc.inc b/recipes/eglibc/eglibc.inc
index 356b838..5c06ae6 100644
--- a/recipes/eglibc/eglibc.inc
+++ b/recipes/eglibc/eglibc.inc
@@ -3,7 +3,7 @@ HOMEPAGE = "http://www.eglibc.org/home"
 SECTION = "libs"
 PRIORITY = "required"
 LICENSE = "LGPL"
-INC_PR = "r8"
+INC_PR = "r9"
 # nptl needs unwind support in gcc, which can't be built without glibc.
 DEPENDS = "virtual/${TARGET_PREFIX}gcc-intermediate linux-libc-headers"
 #this leads to circular deps, so lets not add it yet
-- 
1.7.0

Re: [PATCH] eglibc:

[Khem Raj]

On Thu, Feb 18, 2010 at 11:32 PM, Thomas Zimmermann <ml@vdm-design.de> wrote:
> Am Freitag 19 Februar 2010 01:28:57 schrieb Khem Raj:
>> On Sun, Feb 14, 2010 at 2:37 PM, Koen Kooi <k.kooi@student.utwente.nl>
> wrote:
>> > -----BEGIN PGP SIGNED MESSAGE-----
>> > Hash: SHA1
>> >
>> > On 14-02-10 23:33, Florian Boor wrote:
>> >> Hi,
>> >>
>> >> Thomas Zimmermann schrieb:
>> >>> * ldd has shebang #!/bin/bash: so add bash RDEPNDS
>> >>
>> >> last time I checked it worked with the Busybox built-in shell as well. I
>> >> wonder if it would be a good idea to verify this and patch ldd for our
>> >> purposes.
>> >
>> > like this:
>> > http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/glibc/gli
>> >bc-2.4/ldd-unbash.patch ?
>>
>> or patch posted in http://sourceware.org/bugzilla/show_bug.cgi?id=832
>> it lets it work as it is if shell is bash.
>>
>> Thx
>>
>> -Khem
> I tried ldd today with busyboy and it was enough to replace just the shebang:
>
> --- /usr/bin/ldd        Fri Feb 19 08:27:44 2010
> +++ /usr/bin/ldd        Fri Feb 19 08:27:51 2010
> @@ -1,4 +1,4 @@
> -#! /bin/bash
> +#! /bin/sh
>  # Copyright (C) 1996-2008, 2009 Free Software Foundation, Inc.
>  # This file is part of the GNU C Library.
>
> I think this is because we have in eglibc:
>
> if x=`set -o` && test "$x" != "${x#*pipefail}" && set -o pipefail ; then
>
> and the second term fails, so set -o pipefail is never executed.

yes thats right.

>
> I will resend this patch.
>
> Thomas
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>