Re: [PATCH] transparent file reader

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

Szymon Janc wrote:
> Hello,
>
> Attached patch makes file reader transparent. It should make adding new filters 
> to file reader easier.
>
> - gzio.h is gone
> - gzio is no more transparent, transparency is handled in grub_file_open()
> - renamed GRUB_ERR_BAD_GZIP_DATA to GRUB_ERR_BAD_IOFILTER_DATA, it will be
>  used by other ios like xzio
>
>   
I like the patch however few comments:
1) How are filters ordered?
2) How would I selectively disable a filter. E.g. for hexdump or when
payload expects compressed data?

+/* Registered filters list.  */
+static grub_io_filter_t grub_io_filter_list = NULL;
+
+void grub_io_register(grub_io_filter_t filter)
+{
+   filter->next = grub_io_filter_list;
+   grub_io_filter_list = filter;
+}
+

list.h can be used for this.

> What do You think about it?
>
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]