From: Benoit PAPILLAULT <benoit.papillault@free.fr>
To: Bob Copeland <me@bobcopeland.com>
Cc: jirislaby@gmail.com, mickflemm@gmail.com,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Fix TX/RX padding for all frames
Date: Tue, 16 Feb 2010 21:39:25 +0100 [thread overview]
Message-ID: <4B7B027D.70701@free.fr> (raw)
In-Reply-To: <20100216004717.GA6844@hash.localnet>
Bob Copeland a écrit :
> On Mon, Feb 15, 2010 at 11:06:29PM +0100, Benoit PAPILLAULT wrote:
>
>>> Can you tell what the functional difference is between the old code and new
>>> code? E.g. a padding that would be incorrectly computed from before?
>>>
>>>
>>>
>> Correct. On some frames padding is incorrect. This patch is more for
>> completeness since incorrect padding is only found by sending every kind
>> of frames using a monitor interface. Moreover, since monitor interface
>> are sometimes used to debug other issues, it's better not to have bugs
>> here.
>>
>
> I meant, can you give an example of such a frame?
>
>
I don't have an ath5k based card at hand. I will try to grab one and
will give an example of said frame. Basically, I followed the same
strategy for ath9k already.
Regards,
Benoit
next prev parent reply other threads:[~2010-02-16 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 23:36 [PATCH] ath5k: Fix TX/RX padding for all frames Benoit Papillault
2010-02-15 20:15 ` Bob Copeland
2010-02-15 22:06 ` Benoit PAPILLAULT
2010-02-16 0:47 ` Bob Copeland
2010-02-16 20:39 ` Benoit PAPILLAULT [this message]
2010-02-17 6:15 ` Jouni Malinen
2010-02-17 7:01 ` Benoit PAPILLAULT
[not found] <--to jirislaby@gmail.com --to mickflemm@gmail.com \>
2010-02-27 12:58 ` Benoit Papillault
-- strict thread matches above, loose matches on Subject: below --
2010-02-27 20:58 [ath5k-devel] " Benoit PAPILLAULT
2010-02-27 22:05 ` Benoit Papillault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7B027D.70701@free.fr \
--to=benoit.papillault@free.fr \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.