[PATCH] rtl818x: small cleanup

[PATCH] rtl818x: small cleanup

[okias]

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]

-2 lines...

-- 
Jabber/XMPP: okias@isgeek.info
SIP VoIP: sip:17474537254@proxy01.sipphone.com

[-- Attachment #2: 0001-wireless-rtl818x-small-cleanup.patch --]
[-- Type: application/octet-stream, Size: 1029 bytes --]

From fbbd51121e6558d103f1f83169cd078e70970a1b Mon Sep 17 00:00:00 2001
From: David Heidelberger <d.okias@gmail.com>
Date: Wed, 17 Feb 2010 17:09:03 +0100
Subject: [PATCH] wireless/rtl818x: small cleanup

---
 drivers/net/wireless/rtl818x/rtl8187_dev.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index 7ba3052..2cc6881 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -1165,7 +1165,7 @@ static void rtl8187_bss_info_changed(struct ieee80211_hw *dev,
 {
 	struct rtl8187_priv *priv = dev->priv;
 	int i;
-	u8 reg;
+	u8 reg = 0;
 
 	if (changed & BSS_CHANGED_BSSID) {
 		mutex_lock(&priv->conf_mutex);
@@ -1175,8 +1175,6 @@ static void rtl8187_bss_info_changed(struct ieee80211_hw *dev,
 
 		if (priv->is_rtl8187b)
 			reg = RTL818X_MSR_ENEDCA;
-		else
-			reg = 0;
 
 		if (is_valid_ether_addr(info->bssid)) {
 			reg |= RTL818X_MSR_INFRA;
-- 
1.7.0

Re: [PATCH] rtl818x: small cleanup

[Larry Finger]

On 02/17/2010 11:05 AM, okias wrote:
> -2 lines...

Your patch is fine, but there are problems in the presentation. For review
purposes, it should be in-line, not as an attachment. The second problem is that
the patch is for rtl8187, not for wireless/rtl818x. There are 2 drivers, soon to
be more, in that particular directory.

Larry

Re: [PATCH] rtl818x: small cleanup

[Hin-Tak Leung]

--- On Wed, 17/2/10, okias <d.okias@gmail.com> wrote:

> -2 lines...

Acked,

The content is fine, but you know the kernel patch submission guide line explicitly states that patches should be in-line (use git-send-mail is easiest).