From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/6] tcg: Optional target implementation of ANDC.
Date: Wed, 17 Feb 2010 11:15:17 -0800 [thread overview]
Message-ID: <4B7C4045.2000006@twiddle.net> (raw)
In-Reply-To: <f43fc5581002171034v3efe616eta13142e5f85cfc56@mail.gmail.com>
On 02/17/2010 10:34 AM, Blue Swirl wrote:
> On Wed, Feb 17, 2010 at 12:10 AM, Richard Henderson <rth@twiddle.net> wrote:
>> Previously ANDC was always implemented by tcg-op.h with
>> an explicit NOT opcode. Allow a target implementation.
>
> I think the convention is to add commented out #defines or #undefs for
> all targets, like sparc in bswap case:
> //#define TCG_TARGET_HAS_bswap32_i32
> //#define TCG_TARGET_HAS_bswap64_i64
> or mips:
> #undef TCG_TARGET_HAS_bswap32_i32
> #undef TCG_TARGET_HAS_bswap16_i32
Apparently that was only done for bswap, because there's a lot of
optional opcodes that are missing everywhere. I suppose I could
add those as a separate patch.
r~
next prev parent reply other threads:[~2010-02-17 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 23:15 [Qemu-devel] [PATCH 0/6] tcg-sparc improvements Richard Henderson
2010-02-16 21:55 ` [Qemu-devel] [PATCH 1/6] tcg-sparc: Implement neg Richard Henderson
2010-02-16 22:02 ` [Qemu-devel] [PATCH 2/6] tcg-sparc: Implement not Richard Henderson
2010-02-16 22:10 ` [Qemu-devel] [PATCH 3/6] tcg: Optional target implementation of ANDC Richard Henderson
2010-02-17 18:34 ` [Qemu-devel] " Blue Swirl
2010-02-17 19:15 ` Richard Henderson [this message]
2010-02-16 22:15 ` [Qemu-devel] [PATCH 4/6] tcg: Optional target implementation of ORC Richard Henderson
2010-02-16 22:21 ` [Qemu-devel] [PATCH 5/6] tcg-sparc: Implement ANDC Richard Henderson
2010-02-16 22:23 ` [Qemu-devel] [PATCH 6/6] tcg-sparc: Implement ORC Richard Henderson
2010-02-17 18:24 ` [Qemu-devel] Re: [PATCH 0/6] tcg-sparc improvements Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7C4045.2000006@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.