From: mbohan@codeaurora.org (Michael Bohan)
To: linux-arm-kernel@lists.infradead.org
Subject: Kernel panic due to page migration accessing memory holes
Date: Thu, 18 Feb 2010 21:48:37 -0800 [thread overview]
Message-ID: <4B7E2635.8010700@codeaurora.org> (raw)
In-Reply-To: <20100219110003.dfe58df8.kamezawa.hiroyu@jp.fujitsu.com>
On 2/18/2010 6:00 PM, KAMEZAWA Hiroyuki wrote:
> memmap for memory holes should be marked as PG_reserved and never be freed
> by free_bootmem(). Then, memmap for memory holes will not be in buddy allocator.
>
> Again, pfn_valid() just show "there is memmap", not for "there is a valid page"
>
ARM seems to have been freeing the memmap holes for a long time. I'm
pretty sure there would be a lot of pushback if we tried to change
that. For example, in my memory map running FLATMEM, I would be
consuming an extra ~7 MB of memory if these structures were not freed.
As a compromise, perhaps we could free everything except the first
'pageblock_nr_pages' in a hole? This would guarantee that
move_freepages() doesn't deference any memory that doesn't belong to the
memmap -- but still only waste a relatively small amount of memory. For
a 4 MB page block, it should only consume an extra 32 KB per hole in the
memory map.
Thanks,
Michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Bohan <mbohan@codeaurora.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Kernel panic due to page migration accessing memory holes
Date: Thu, 18 Feb 2010 21:48:37 -0800 [thread overview]
Message-ID: <4B7E2635.8010700@codeaurora.org> (raw)
In-Reply-To: <20100219110003.dfe58df8.kamezawa.hiroyu@jp.fujitsu.com>
On 2/18/2010 6:00 PM, KAMEZAWA Hiroyuki wrote:
> memmap for memory holes should be marked as PG_reserved and never be freed
> by free_bootmem(). Then, memmap for memory holes will not be in buddy allocator.
>
> Again, pfn_valid() just show "there is memmap", not for "there is a valid page"
>
ARM seems to have been freeing the memmap holes for a long time. I'm
pretty sure there would be a lot of pushback if we tried to change
that. For example, in my memory map running FLATMEM, I would be
consuming an extra ~7 MB of memory if these structures were not freed.
As a compromise, perhaps we could free everything except the first
'pageblock_nr_pages' in a hole? This would guarantee that
move_freepages() doesn't deference any memory that doesn't belong to the
memmap -- but still only waste a relatively small amount of memory. For
a 4 MB page block, it should only consume an extra 32 KB per hole in the
memory map.
Thanks,
Michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Bohan <mbohan@codeaurora.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Kernel panic due to page migration accessing memory holes
Date: Thu, 18 Feb 2010 21:48:37 -0800 [thread overview]
Message-ID: <4B7E2635.8010700@codeaurora.org> (raw)
In-Reply-To: <20100219110003.dfe58df8.kamezawa.hiroyu@jp.fujitsu.com>
On 2/18/2010 6:00 PM, KAMEZAWA Hiroyuki wrote:
> memmap for memory holes should be marked as PG_reserved and never be freed
> by free_bootmem(). Then, memmap for memory holes will not be in buddy allocator.
>
> Again, pfn_valid() just show "there is memmap", not for "there is a valid page"
>
ARM seems to have been freeing the memmap holes for a long time. I'm
pretty sure there would be a lot of pushback if we tried to change
that. For example, in my memory map running FLATMEM, I would be
consuming an extra ~7 MB of memory if these structures were not freed.
As a compromise, perhaps we could free everything except the first
'pageblock_nr_pages' in a hole? This would guarantee that
move_freepages() doesn't deference any memory that doesn't belong to the
memmap -- but still only waste a relatively small amount of memory. For
a 4 MB page block, it should only consume an extra 32 KB per hole in the
memory map.
Thanks,
Michael
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-19 5:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 0:45 Kernel panic due to page migration accessing memory holes Michael Bohan
2010-02-18 0:45 ` Michael Bohan
2010-02-18 0:45 ` Michael Bohan
2010-02-18 1:03 ` KAMEZAWA Hiroyuki
2010-02-18 1:03 ` KAMEZAWA Hiroyuki
2010-02-18 1:03 ` KAMEZAWA Hiroyuki
2010-02-18 8:22 ` Michael Bohan
2010-02-18 8:22 ` Michael Bohan
2010-02-18 8:22 ` Michael Bohan
2010-02-18 9:36 ` KAMEZAWA Hiroyuki
2010-02-18 9:36 ` KAMEZAWA Hiroyuki
2010-02-18 9:36 ` KAMEZAWA Hiroyuki
2010-02-18 10:04 ` Mel Gorman
2010-02-18 10:04 ` Mel Gorman
2010-02-18 10:04 ` Mel Gorman
2010-02-19 1:47 ` Michael Bohan
2010-02-19 1:47 ` Michael Bohan
2010-02-19 1:47 ` Michael Bohan
2010-02-19 2:00 ` KAMEZAWA Hiroyuki
2010-02-19 2:00 ` KAMEZAWA Hiroyuki
2010-02-19 2:00 ` KAMEZAWA Hiroyuki
2010-02-19 5:48 ` Michael Bohan [this message]
2010-02-19 5:48 ` Michael Bohan
2010-02-19 5:48 ` Michael Bohan
2010-02-19 6:10 ` KAMEZAWA Hiroyuki
2010-02-19 6:10 ` KAMEZAWA Hiroyuki
2010-02-19 6:10 ` KAMEZAWA Hiroyuki
2010-02-19 8:21 ` KAMEZAWA Hiroyuki
2010-02-19 8:21 ` KAMEZAWA Hiroyuki
2010-02-19 8:21 ` KAMEZAWA Hiroyuki
2010-02-19 8:30 ` Russell King - ARM Linux
2010-02-19 8:30 ` Russell King - ARM Linux
2010-02-19 8:30 ` Russell King - ARM Linux
2010-02-19 13:48 ` Mel Gorman
2010-02-19 13:48 ` Mel Gorman
2010-02-19 13:48 ` Mel Gorman
2010-02-18 8:53 ` Russell King - ARM Linux
2010-02-18 8:53 ` Russell King - ARM Linux
2010-02-18 8:53 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7E2635.8010700@codeaurora.org \
--to=mbohan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.