All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: armbru@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
	gleb@redhat.com, hch@lst.de
Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block
Date: Fri, 19 Feb 2010 15:13:30 -0600	[thread overview]
Message-ID: <4B7EFEFA.60501@codemonkey.ws> (raw)
In-Reply-To: <1266250769-5816-1-git-send-email-kwolf@redhat.com>

On 02/15/2010 10:19 AM, Kevin Wolf wrote:
> The current implementation of alloc_refcount_block and grow_refcount_table has
> fundamental problems regarding error handling. There are some places where an
> I/O error means that the image is going to be corrupted. I have found that the
> only way to fix this is to completely rewrite the thing.
>
> Just sending as an RFC to the list hasn't generated a lot of comments (to be
> precise, not a single one). This is a critical part of qcow2 and needs reviews.
> So let's try it another way: People in CC, please give it a review. Sooner or
> later some of you will need to do so anyway.
>    

Should I apply this series?  I still don't see any review comments.

Regards,

Anthony Liguori

> Kevin Wolf (3):
>    qcow2: Factor next_refcount_table_size out
>    qcow2: Rewrite alloc_refcount_block/grow_refcount_table
>    qcow2: More check for qemu-img check
>
>   block/qcow2-refcount.c |  334 +++++++++++++++++++++++++++++++++++-------------
>   1 files changed, 244 insertions(+), 90 deletions(-)
>
>
>
>
>    

  parent reply	other threads:[~2010-02-19 21:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 16:19 [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block Kevin Wolf
2010-02-15 16:19 ` [Qemu-devel] [PATCH 1/3] qcow2: Factor next_refcount_table_size out Kevin Wolf
2010-02-18 10:40   ` [Qemu-devel] " Juan Quintela
2010-02-15 16:19 ` [Qemu-devel] [PATCH 2/3] qcow2: Rewrite alloc_refcount_block/grow_refcount_table Kevin Wolf
2010-02-18 12:02   ` [Qemu-devel] " Juan Quintela
2010-02-15 16:19 ` [Qemu-devel] [PATCH 3/3] qcow2: More checks for qemu-img check Kevin Wolf
2010-02-18 12:11   ` [Qemu-devel] " Juan Quintela
2010-02-19 21:13 ` Anthony Liguori [this message]
2010-02-20  1:49   ` [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block Juan Quintela
2010-02-20 17:02     ` Anthony Liguori
2010-02-22  8:54     ` Kevin Wolf
2010-02-22  9:55       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7EFEFA.60501@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.