Re: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

[Anthony Liguori <anthony@codemonkey.ws>]

On 02/19/2010 07:49 PM, Juan Quintela wrote:
> Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>> On 02/15/2010 10:19 AM, Kevin Wolf wrote:
>>      
>>> The current implementation of alloc_refcount_block and grow_refcount_table has
>>> fundamental problems regarding error handling. There are some places where an
>>> I/O error means that the image is going to be corrupted. I have found that the
>>> only way to fix this is to completely rewrite the thing.
>>>
>>> Just sending as an RFC to the list hasn't generated a lot of comments (to be
>>> precise, not a single one). This is a critical part of qcow2 and needs reviews.
>>> So let's try it another way: People in CC, please give it a review. Sooner or
>>> later some of you will need to do so anyway.
>>>
>>>        
>> Should I apply this series?  I still don't see any review comments.
>>      
> I sent review comments on the 18th.  I expect Kevin to address them.  I
> talked with him on irc while doing the review (i.e. he knows about
> them).
>    

You're right, I missed it.  Thanks.

Regards,

Anthony Liguori

> Kevin???
>
> Later, Juan.
>
>
>
>