All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@us.ibm.com>,
	Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 8/9] KVM: Rework of guest debug state writing
Date: Sun, 21 Feb 2010 11:26:55 +0200	[thread overview]
Message-ID: <4B80FC5F.1020804@redhat.com> (raw)
In-Reply-To: <68e0d2c45f24b4c183cc1827902afc46d280d89b.1266603744.git.jan.kiszka@siemens.com>

On 02/19/2010 08:22 PM, Jan Kiszka wrote:
> So far we synchronized any dirty VCPU state back into the kernel before
> updating the guest debug state. This was a tribute to a deficite in x86
> kernels before 2.6.33. But as this is an arch-dependent issue, it is
> better handle in the x86 part of KVM and remove the writeback point for
> generic code. This also avoids overwriting the flushed state later on if
> user space decides to change some more registers before resuming the
> guest.
>    

Inferring one property of kvm.ko from another is not good, since it 
creates problems with backports.  Better to create a separate KVM_CAP_ 
for the issue you're testing (and we can retroactively apply it to 2.6.33).

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Gleb Natapov <gleb@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 8/9] KVM: Rework of guest debug state writing
Date: Sun, 21 Feb 2010 11:26:55 +0200	[thread overview]
Message-ID: <4B80FC5F.1020804@redhat.com> (raw)
In-Reply-To: <68e0d2c45f24b4c183cc1827902afc46d280d89b.1266603744.git.jan.kiszka@siemens.com>

On 02/19/2010 08:22 PM, Jan Kiszka wrote:
> So far we synchronized any dirty VCPU state back into the kernel before
> updating the guest debug state. This was a tribute to a deficite in x86
> kernels before 2.6.33. But as this is an arch-dependent issue, it is
> better handle in the x86 part of KVM and remove the writeback point for
> generic code. This also avoids overwriting the flushed state later on if
> user space decides to change some more registers before resuming the
> guest.
>    

Inferring one property of kvm.ko from another is not good, since it 
creates problems with backports.  Better to create a separate KVM_CAP_ 
for the issue you're testing (and we can retroactively apply it to 2.6.33).

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-02-21  9:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 18:22 [PATCH 0/9] qemu-kvm: Extended use of upstream code Jan Kiszka
2010-02-19 18:22 ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 1/9] qemu-kvm: Drop vmport changes Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 2/9] qemu-kvm: Clean up register access API Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-21  9:25   ` Avi Kivity
2010-02-21  9:25     ` [Qemu-devel] " Avi Kivity
2010-02-19 18:22 ` [PATCH 3/9] qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 4/9] qemu-kvm: Use upstream kvm_setup_guest_memory Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 5/9] qemu-kvm: Use some more upstream prototypes Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 6/9] qemu-kvm: Use upstream kvm_arch_get_supported_cpuid Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 7/9] qemu-kvm: Use upstream kvm_pit_in_kernel Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-19 18:22 ` [PATCH 8/9] KVM: Rework of guest debug state writing Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-21  9:26   ` Avi Kivity [this message]
2010-02-21  9:26     ` [Qemu-devel] " Avi Kivity
2010-02-19 18:22 ` [PATCH 9/9] qemu-kvm: Use upstream guest debug code Jan Kiszka
2010-02-19 18:22   ` [Qemu-devel] " Jan Kiszka
2010-02-21  9:20 ` [PATCH 0/9] qemu-kvm: Extended use of upstream code Avi Kivity
2010-02-21  9:20   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B80FC5F.1020804@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.