From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] KVM: PPC: Allocate vcpu struct using vmalloc
Date: Sun, 21 Feb 2010 12:29:00 +0000 [thread overview]
Message-ID: <4B81270C.4060303@redhat.com> (raw)
In-Reply-To: <1266578673-32254-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
On 02/19/2010 01:24 PM, Alexander Graf wrote:
> We used to use get_free_pages to allocate our vcpu struct. Unfortunately
> that call failed on me several times after my machine had a big enough
> uptime, as memory became too fragmented by then.
>
> Fortunately, we don't need it to be page aligned any more! We can just
> vmalloc it and everything's great.
>
Applied, thanks.
We have the same problem in x86 (though never observed it in practice);
my plan there is to split the various structure so they take less than a
page.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] KVM: PPC: Allocate vcpu struct using vmalloc
Date: Sun, 21 Feb 2010 14:29:00 +0200 [thread overview]
Message-ID: <4B81270C.4060303@redhat.com> (raw)
In-Reply-To: <1266578673-32254-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
On 02/19/2010 01:24 PM, Alexander Graf wrote:
> We used to use get_free_pages to allocate our vcpu struct. Unfortunately
> that call failed on me several times after my machine had a big enough
> uptime, as memory became too fragmented by then.
>
> Fortunately, we don't need it to be page aligned any more! We can just
> vmalloc it and everything's great.
>
Applied, thanks.
We have the same problem in x86 (though never observed it in practice);
my plan there is to split the various structure so they take less than a
page.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-02-21 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 11:24 [PATCH] KVM: PPC: Allocate vcpu struct using vmalloc Alexander Graf
2010-02-19 11:24 ` Alexander Graf
[not found] ` <1266578673-32254-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-02-21 12:29 ` Avi Kivity [this message]
2010-02-21 12:29 ` Avi Kivity
2010-02-21 14:50 ` Alexander Graf
2010-02-21 15:08 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B81270C.4060303@redhat.com \
--to=avi@redhat.com \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.