Re: [PATCH 10/11] omap: musb: get rid of dyn_fifo

[Thomas Weber <weber@corscience.de>]

Tony Lindgren wrote:
> From: Felipe Balbi <felipe.balbi@nokia.com>
>
> that's deprecated as we can check dyn_fifo from
> CONFIGDATA register.
>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm/mach-omap2/usb-musb.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 2221a6c..85feb60 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -49,7 +49,6 @@ static struct resource musb_resources[] = {
>  
>  static struct musb_hdrc_config musb_config = {
>  	.multipoint	= 1,
> -	.dyn_fifo	= 1,
>  	.num_eps	= 16,
>  	.ram_bits	= 12,
>  };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>   
Hi,

I think this patch breaks musb_hdrc.

In musb_core_init is musb->config->dyn_fifo checked but is never set.

So I get the following dmesg output:

musb_hdrc: ConfigData=0xde (UTMI-8, dyn FIFOs, bulk combine, bulk split,
HB-ISO Rx, HB-ISO Tx, SoftConn)
musb_hdrc: MHDRC RTL version 1.400
musb_core_init 1405: reconfigure software for Dynamic FIFOs
musb_hdrc musb_hdrc: musb_init_controller failed with status -19

Thomas