Re: [Patch 2/3] chcli cleanup: gcc warning

[Jeff Garzik <jeff@garzik.org>]

On 03/02/2010 09:41 PM, Pete Zaitcev wrote:
> On Tue, 02 Mar 2010 21:18:24 -0500
> Jeff Garzik<jeff@garzik.org>  wrote:
>
>> Note that your mailer is mangling patches via "quoted-printable":
>
> No, it does not. Look at this:
>
> [zaitcev@lembas ~]$ grep fstat Mail/inbox/*
> Mail/inbox/10891:# diffstat add_function.patch hub_revision_ACPI_modes.patch
> Mail/inbox/15830:-      rc =3D fstat(fd,&stat);
> Mail/inbox/15830:+      rc =3D fstat(fd,&st);
> Mail/inbox/15833:-      rc = fstat(fd,&stat);
> Mail/inbox/15833:+      rc = fstat(fd,&statb);
>
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: quoted-printable
>> [...]
>> =20
>> -	rc =3D fstat(fd,&stat);
>> +	rc =3D fstat(fd,&st);
>>    	if (rc) {
>
> Clearly, its your own message you are complaining about, not mine,
> because my patch changed the variable to 'statb' (and it's not
> corrupt, see above grep), while your patch changed to it to 'st'.
> "My mailer" did not even touch it. Heck, I did not even see that
> message (although I did a git pull to see if the "note" you promised
> was attached to the changelog).

I manually changed s/statb/st/ using vi directly on the Berkeley mbox 
file.  Don't get confused by that.

Ignore the variable name change and look at the quoted-printable 
artifacts "=3D", "=20", etc...

	Jeff