[Qemu-devel] Re: Build failure for upstream qemu 04-03-2010

[Stefan Weil <weil@mail.berlios.de>]

Anthony Liguori schrieb:
> It was broken by:
>
> commit da51e79b7ff2126cc2448749d657a4f6e3b1270f
> Author: Stefan Weil <weil@mail.berlios.de>
> Date:   Tue Mar 2 22:37:44 2010 +0100
>
>     eepro100: Support gpxe boot for all eepro100 devices
>
>     Only two boot ROM files are needed for all devices.
>
>     * Add these GPXE ROM files using new naming convention
>       (as discussed on qemu-devel). Both files were created
>       with http://rom-o-matic.net/, PCI vendor / device ids
>       as in ROM filenames and option BANNER_TIMEOUT = 0.
>
>     * Remove old PXE ROM file for i82559er.
>       It was replaced by gpxe-eepro100-80861209.rom.
>
>     * Update pc-bios/README (and sort entries).
>
>     Full support still needs additional eepro100 fixes.
>
>     Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> Stefan/Michael, can you please submit a fix?  The Makefile wasn't
> adjusted for the new PXE naming.
>
> Really, the roms should not have been renamed like this in this sort
> of patch.  If we switch to gpxe as a prefix, we should rename all of
> the roms at once as opposed to having some roms with a pxe name and
> others with gpxe.
>
> Regards,
>
> Anthony Liguori

Hi Antony,

sorry for the missing change in Makefile.
I'll send a patch which fixes that.

The new naming scheme was an RFC on qemu-devel.
I had to choose some name (because now there are two
instead of one ROM files for eepro100.c, and the
choosen names are the result from the discussion.

I agree that all ROM files with GPXE should have
gpxe-names, but there is no need to do this in
one step.

Regards,
Stefan Weil