[Qemu-devel] Build failure for upstream qemu 04-03-2010

[Qemu-devel] Build failure for upstream qemu 04-03-2010

[Lucas Meneghel Rodrigues]

Hi folks, I found this problem trying to build qemu from the qemu.git
repo:

03/04 13:07:34 ERROR|       kvm:0061| Test failed: Command <make install> failed, rc=2, Command returned non-zero exit status
* Command: 
    make install
Exit status: 2
Duration: 0

stdout:
install -d -m0755 -p "/usr/local/autotest/tests/kvm/build/etc/qemu"
install -m0644 -p /usr/local/autotest/tests/kvm/src/kvm_userspace/sysconfigs/target/target-x86_64.conf "/usr/local/autotest/tests/kvm/build/etc/qemu"
install -d -m0755 -p "/usr/local/autotest/tests/kvm/build/bin"
install -m0755 -p  qemu-nbd qemu-img qemu-io  "/usr/local/autotest/tests/kvm/build/bin"
install -d -m0755 -p "/usr/local/autotest/tests/kvm/build/share/qemu"
set -e; for x in bios.bin vgabios.bin vgabios-cirrus.bin ppc_rom.bin video.x openbios-sparc32 openbios-sparc64 openbios-ppc pxe-e1000.bin pxe-i82559er.bin pxe-ne2k_pci.bin pxe-pcnet.bin pxe-rtl8139.bin pxe-virtio.bin bamboo.dtb petalogix-s3adsp1800.dtb multiboot.bin linuxboot.bin; do \
		install -m0644 -p /usr/local/autotest/tests/kvm/src/kvm_userspace/pc-bios/$x "/usr/local/autotest/tests/kvm/build/share/qemu"; \
	done
stderr:
install: cannot stat `/usr/local/autotest/tests/kvm/src/kvm_userspace/pc-bios/pxe-i82559er.bin': No such file or directory
make: *** [install] Error 1

The exact commit where the problem was found:

03/04 12:59:44 INFO | kvm_utils:0367| Commit hash for git://git.savannah.nongnu.org/qemu.git is deb4203dc9ebba6992ac1d583773c143a014e15a (no tag found)

Please let me know if you need more information about the problem

[Qemu-devel] Re: Build failure for upstream qemu 04-03-2010

[Anthony Liguori]

It was broken by:

commit da51e79b7ff2126cc2448749d657a4f6e3b1270f
Author: Stefan Weil <weil@mail.berlios.de>
Date:   Tue Mar 2 22:37:44 2010 +0100

     eepro100: Support gpxe boot for all eepro100 devices

     Only two boot ROM files are needed for all devices.

     * Add these GPXE ROM files using new naming convention
       (as discussed on qemu-devel). Both files were created
       with http://rom-o-matic.net/, PCI vendor / device ids
       as in ROM filenames and option BANNER_TIMEOUT = 0.

     * Remove old PXE ROM file for i82559er.
       It was replaced by gpxe-eepro100-80861209.rom.

     * Update pc-bios/README (and sort entries).

     Full support still needs additional eepro100 fixes.

     Signed-off-by: Stefan Weil <weil@mail.berlios.de>
     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>


Stefan/Michael, can you please submit a fix?  The Makefile wasn't 
adjusted for the new PXE naming.

Really, the roms should not have been renamed like this in this sort of 
patch.  If we switch to gpxe as a prefix, we should rename all of the 
roms at once as opposed to having some roms with a pxe name and others 
with gpxe.

Regards,

Anthony Liguori

On 03/04/2010 12:20 PM, Lucas Meneghel Rodrigues wrote:
> Hi folks, I found this problem trying to build qemu from the qemu.git
> repo:
>
> 03/04 13:07:34 ERROR|       kvm:0061| Test failed: Command<make install>  failed, rc=2, Command returned non-zero exit status
> * Command:
>      make install
> Exit status: 2
> Duration: 0
>
> stdout:
> install -d -m0755 -p "/usr/local/autotest/tests/kvm/build/etc/qemu"
> install -m0644 -p /usr/local/autotest/tests/kvm/src/kvm_userspace/sysconfigs/target/target-x86_64.conf "/usr/local/autotest/tests/kvm/build/etc/qemu"
> install -d -m0755 -p "/usr/local/autotest/tests/kvm/build/bin"
> install -m0755 -p  qemu-nbd qemu-img qemu-io  "/usr/local/autotest/tests/kvm/build/bin"
> install -d -m0755 -p "/usr/local/autotest/tests/kvm/build/share/qemu"
> set -e; for x in bios.bin vgabios.bin vgabios-cirrus.bin ppc_rom.bin video.x openbios-sparc32 openbios-sparc64 openbios-ppc pxe-e1000.bin pxe-i82559er.bin pxe-ne2k_pci.bin pxe-pcnet.bin pxe-rtl8139.bin pxe-virtio.bin bamboo.dtb petalogix-s3adsp1800.dtb multiboot.bin linuxboot.bin; do \
> 		install -m0644 -p /usr/local/autotest/tests/kvm/src/kvm_userspace/pc-bios/$x "/usr/local/autotest/tests/kvm/build/share/qemu"; \
> 	done
> stderr:
> install: cannot stat `/usr/local/autotest/tests/kvm/src/kvm_userspace/pc-bios/pxe-i82559er.bin': No such file or directory
> make: *** [install] Error 1
>
> The exact commit where the problem was found:
>
> 03/04 12:59:44 INFO | kvm_utils:0367| Commit hash for git://git.savannah.nongnu.org/qemu.git is deb4203dc9ebba6992ac1d583773c143a014e15a (no tag found)
>
> Please let me know if you need more information about the problem
>
>
>    

[Qemu-devel] Re: Build failure for upstream qemu 04-03-2010

[Stefan Weil]

Anthony Liguori schrieb:
> It was broken by:
>
> commit da51e79b7ff2126cc2448749d657a4f6e3b1270f
> Author: Stefan Weil <weil@mail.berlios.de>
> Date:   Tue Mar 2 22:37:44 2010 +0100
>
>     eepro100: Support gpxe boot for all eepro100 devices
>
>     Only two boot ROM files are needed for all devices.
>
>     * Add these GPXE ROM files using new naming convention
>       (as discussed on qemu-devel). Both files were created
>       with http://rom-o-matic.net/, PCI vendor / device ids
>       as in ROM filenames and option BANNER_TIMEOUT = 0.
>
>     * Remove old PXE ROM file for i82559er.
>       It was replaced by gpxe-eepro100-80861209.rom.
>
>     * Update pc-bios/README (and sort entries).
>
>     Full support still needs additional eepro100 fixes.
>
>     Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> Stefan/Michael, can you please submit a fix?  The Makefile wasn't
> adjusted for the new PXE naming.
>
> Really, the roms should not have been renamed like this in this sort
> of patch.  If we switch to gpxe as a prefix, we should rename all of
> the roms at once as opposed to having some roms with a pxe name and
> others with gpxe.
>
> Regards,
>
> Anthony Liguori

Hi Antony,

sorry for the missing change in Makefile.
I'll send a patch which fixes that.

The new naming scheme was an RFC on qemu-devel.
I had to choose some name (because now there are two
instead of one ROM files for eepro100.c, and the
choosen names are the result from the discussion.

I agree that all ROM files with GPXE should have
gpxe-names, but there is no need to do this in
one step.

Regards,
Stefan Weil

[Qemu-devel] [PATCH] Makefile: Fix names of GPXE ROM files

[Stefan Weil]

da51e79b7ff2126cc2448749d657a4f6e3b1270f added two new ROM files
and removed an old one for eepro100.c.

These changes were missing in Makefile (which resulted
in a broken "make install").

Reported by Lucas Meneghel Rodrigues, thanks.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 4af1317..46a337f 100644
--- a/Makefile
+++ b/Makefile
@@ -172,7 +172,9 @@ common  de-ch  es     fo  fr-ca  hu     ja  mk  nl-be      pt  sl     tr
 ifdef INSTALL_BLOBS
 BLOBS=bios.bin vgabios.bin vgabios-cirrus.bin ppc_rom.bin \
 video.x openbios-sparc32 openbios-sparc64 openbios-ppc \
-pxe-e1000.bin pxe-i82559er.bin \
+gpxe-eepro100-80861209.rom \
+gpxe-eepro100-80861229.rom \
+pxe-e1000.bin \
 pxe-ne2k_pci.bin pxe-pcnet.bin \
 pxe-rtl8139.bin pxe-virtio.bin \
 bamboo.dtb petalogix-s3adsp1800.dtb \
-- 
1.7.0